From a7576c14ada6dcbe598db566e13170e2f7e1be5a Mon Sep 17 00:00:00 2001
From: bobo <bobo.yang@merico.dev>
Date: Thu, 18 Apr 2024 10:56:44 +0800
Subject: [PATCH] fix: Simplify provider config initialization in ConfigStore

- Streamline the initialization of config models and providers
- Ensure default provider settings for openai and devchat on first access
- Improve code readability and efficiency by using logical OR for defaults
---
 src/views/stores/ConfigStore.ts | 25 ++++++++++---------------
 1 file changed, 10 insertions(+), 15 deletions(-)

diff --git a/src/views/stores/ConfigStore.ts b/src/views/stores/ConfigStore.ts
index b441867..cbd9e31 100644
--- a/src/views/stores/ConfigStore.ts
+++ b/src/views/stores/ConfigStore.ts
@@ -68,21 +68,16 @@ export const ConfigStore = types
       this.updateSettle(false);
       let needUpdate = false;
       const newConfig = { ...data };
-      if (!data.models) {
-        newConfig.models = {};
-      }
-      if (!newConfig.providers?.openai) {
-        newConfig.providers.openai = {
-          api_key: "",
-          api_base: "",
-        };
-      }
-      if (!newConfig.providers?.devchat) {
-        newConfig.providers.devchat = {
-          api_key: "",
-          api_base: "",
-        };
-      }
+      newConfig.models = newConfig.models || {};
+      newConfig.providers = newConfig.providers || {};
+      newConfig.providers.openai = newConfig.providers.openai || {
+        api_key: "",
+        api_base: "",
+      };
+      newConfig.providers.devchat = newConfig.providers.devchat || {
+        api_key: "",
+        api_base: "",
+      };
 
       self.modelsTemplate.forEach((item) => {
         const currentModel: any = {