2023-05-03 11:06:20 +02:00
|
|
|
== Why is this an issue?
|
|
|
|
|
2023-10-18 18:21:32 +02:00
|
|
|
:operationName: function
|
2020-06-30 14:49:38 +02:00
|
|
|
|
2023-10-18 18:21:32 +02:00
|
|
|
include::../description.adoc[]
|
2020-06-30 12:47:33 +02:00
|
|
|
|
2023-10-18 18:21:32 +02:00
|
|
|
=== Exceptions
|
|
|
|
|
|
|
|
This rule doesn't raise an issue on empty methods in abstract classes.
|
2020-06-30 12:47:33 +02:00
|
|
|
|
2022-02-04 17:28:24 +01:00
|
|
|
[source,php]
|
2020-06-30 12:47:33 +02:00
|
|
|
----
|
2023-10-18 18:21:32 +02:00
|
|
|
abstract class Animal {
|
|
|
|
public function speak() {} // default implementation ignored
|
2020-06-30 12:47:33 +02:00
|
|
|
}
|
|
|
|
----
|
|
|
|
|
2023-10-18 18:21:32 +02:00
|
|
|
== How to fix it
|
2020-06-30 12:47:33 +02:00
|
|
|
|
2023-10-18 18:21:32 +02:00
|
|
|
=== Code examples
|
|
|
|
|
|
|
|
==== Noncompliant code example
|
|
|
|
|
|
|
|
[source,php,diff-id=1,diff-type=noncompliant]
|
2020-06-30 12:47:33 +02:00
|
|
|
----
|
2023-10-18 18:21:32 +02:00
|
|
|
public function shouldNotBeEmpty() { // Noncompliant - method is empty
|
2020-06-30 12:47:33 +02:00
|
|
|
}
|
|
|
|
|
2023-10-18 18:21:32 +02:00
|
|
|
public function notImplemented() { // Noncompliant - method is empty
|
2020-06-30 12:47:33 +02:00
|
|
|
}
|
|
|
|
|
2023-10-18 18:21:32 +02:00
|
|
|
public function emptyOnPurpose() { // Noncompliant - method is empty
|
|
|
|
}
|
|
|
|
----
|
2020-06-30 12:47:33 +02:00
|
|
|
|
2023-10-18 18:21:32 +02:00
|
|
|
==== Compliant solution
|
2020-06-30 14:49:38 +02:00
|
|
|
|
2023-10-18 18:21:32 +02:00
|
|
|
[source,php,diff-id=1,diff-type=compliant]
|
2020-06-30 12:47:33 +02:00
|
|
|
----
|
2023-10-18 18:21:32 +02:00
|
|
|
public function shouldNotBeEmpty() {
|
|
|
|
doSomething();
|
|
|
|
}
|
|
|
|
|
|
|
|
public function notImplemented() {
|
|
|
|
throw new Exception('notImplemented() cannot be performed because ...');
|
|
|
|
}
|
|
|
|
|
|
|
|
public function emptyOnPurpose() {
|
|
|
|
// comment explaining why the method is empty
|
2020-06-30 12:47:33 +02:00
|
|
|
}
|
|
|
|
----
|
2021-06-02 20:44:38 +02:00
|
|
|
|
2021-06-03 09:05:38 +02:00
|
|
|
ifdef::env-github,rspecator-view[]
|
2021-09-20 15:38:42 +02:00
|
|
|
|
|
|
|
'''
|
|
|
|
== Implementation Specification
|
|
|
|
(visible only on this page)
|
|
|
|
|
|
|
|
include::../message.adoc[]
|
|
|
|
|
2021-06-08 15:52:13 +02:00
|
|
|
'''
|
2021-06-02 20:44:38 +02:00
|
|
|
== Comments And Links
|
|
|
|
(visible only on this page)
|
|
|
|
|
|
|
|
include::../comments-and-links.adoc[]
|
2023-06-22 10:38:01 +02:00
|
|
|
|
2021-06-03 09:05:38 +02:00
|
|
|
endif::env-github,rspecator-view[]
|