2023-05-03 11:06:20 +02:00
|
|
|
== Why is this an issue?
|
|
|
|
|
2020-06-30 12:47:33 +02:00
|
|
|
include::../description.adoc[]
|
|
|
|
|
2023-05-03 11:06:20 +02:00
|
|
|
=== Noncompliant code example
|
2020-06-30 12:47:33 +02:00
|
|
|
|
2022-02-04 17:28:24 +01:00
|
|
|
[source,flex]
|
2020-06-30 12:47:33 +02:00
|
|
|
----
|
|
|
|
public function func(foo:Number, bar:Number):void
|
|
|
|
{
|
|
|
|
switch (foo)
|
|
|
|
{
|
|
|
|
case 1:
|
|
|
|
// do something
|
|
|
|
break;
|
|
|
|
case 2:
|
|
|
|
switch (bar) // Noncompliant
|
|
|
|
{
|
|
|
|
case 89: // It's easy to lose sight of what's being tested; is it foo or bar?
|
|
|
|
// ...
|
|
|
|
break;
|
|
|
|
case 90:
|
|
|
|
// ...
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
case 3:
|
|
|
|
// do something
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
----
|
|
|
|
|
2023-05-03 11:06:20 +02:00
|
|
|
=== Compliant solution
|
2020-06-30 12:47:33 +02:00
|
|
|
|
2022-02-04 17:28:24 +01:00
|
|
|
[source,flex]
|
2020-06-30 12:47:33 +02:00
|
|
|
----
|
|
|
|
public function func(foo:Number, bar:Number):void
|
|
|
|
{
|
|
|
|
switch (foo)
|
|
|
|
{
|
|
|
|
case 1:
|
|
|
|
// ...
|
|
|
|
break;
|
|
|
|
case 2:
|
|
|
|
handleBar(bar);
|
|
|
|
break;
|
|
|
|
case 3:
|
|
|
|
// ...
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
public function handleBar(bar:Number):void
|
|
|
|
{
|
|
|
|
switch (bar)
|
|
|
|
{
|
|
|
|
case 89:
|
|
|
|
// ...
|
|
|
|
break;
|
|
|
|
case 90:
|
|
|
|
// ...
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
----
|
2021-06-02 20:44:38 +02:00
|
|
|
|
2021-06-03 09:05:38 +02:00
|
|
|
ifdef::env-github,rspecator-view[]
|
2021-09-20 15:38:42 +02:00
|
|
|
|
|
|
|
'''
|
|
|
|
== Implementation Specification
|
|
|
|
(visible only on this page)
|
|
|
|
|
|
|
|
include::../message.adoc[]
|
|
|
|
|
2021-06-08 15:52:13 +02:00
|
|
|
'''
|
2021-06-02 20:44:38 +02:00
|
|
|
== Comments And Links
|
|
|
|
(visible only on this page)
|
|
|
|
|
|
|
|
include::../comments-and-links.adoc[]
|
2023-06-22 10:38:01 +02:00
|
|
|
|
2021-06-03 09:05:38 +02:00
|
|
|
endif::env-github,rspecator-view[]
|