rspec/rules/S1821/flex/rule.adoc

87 lines
1.2 KiB
Plaintext
Raw Permalink Normal View History

== Why is this an issue?
2020-06-30 12:47:33 +02:00
include::../description.adoc[]
=== Noncompliant code example
2020-06-30 12:47:33 +02:00
2022-02-04 17:28:24 +01:00
[source,flex]
2020-06-30 12:47:33 +02:00
----
public function func(foo:Number, bar:Number):void
{
switch (foo)
{
case 1:
// do something
break;
case 2:
switch (bar) // Noncompliant
{
case 89: // It's easy to lose sight of what's being tested; is it foo or bar?
// ...
break;
case 90:
// ...
break;
}
break;
case 3:
// do something
break;
default:
break;
}
}
----
=== Compliant solution
2020-06-30 12:47:33 +02:00
2022-02-04 17:28:24 +01:00
[source,flex]
2020-06-30 12:47:33 +02:00
----
public function func(foo:Number, bar:Number):void
{
switch (foo)
{
case 1:
// ...
break;
case 2:
handleBar(bar);
break;
case 3:
// ...
break;
default:
break;
}
}
public function handleBar(bar:Number):void
{
switch (bar)
{
case 89:
// ...
break;
case 90:
// ...
break;
}
}
----
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
include::../message.adoc[]
'''
== Comments And Links
(visible only on this page)
include::../comments-and-links.adoc[]
endif::env-github,rspecator-view[]