rspec/rules/S2925/comments-and-links.adoc

22 lines
723 B
Plaintext
Raw Permalink Normal View History

'''
== Comments And Links
(visible only on this page)
=== on 12 May 2015, 14:52:51 David Gageot wrote:
lgtm
=== on 20 May 2015, 15:08:39 Nicolas Peru wrote:
Ok.
=== on 21 Aug 2015, 09:21:47 Michael Gumowski wrote:
WDYT about changes [~duarte.meneses]?
=== on 21 Aug 2015, 09:29:58 Duarte Meneses wrote:
Looks good.
Only suggestion I have is to put the timeout in the solution longer (2/3s?), otherwise it wouldn't fix the problem of dependency on the environment.
With awaitility we can use larger timeouts but still proceed quickly as soon as the polling conditions is satisfied.
=== on 21 Aug 2015, 09:35:55 Michael Gumowski wrote:
Ok, updated. Thanks for your feedback! Feels free to modify it directly next time!