76 lines
1.2 KiB
Plaintext
76 lines
1.2 KiB
Plaintext
|
|
||
|
|
include::../summary.adoc[]
|
||
|
|
|
||
|
|
== Why is this an issue?
|
||
|
|
|
||
|
|
include::../rationale.adoc[]
|
||
|
|
|
||
|
|
include::../impact.adoc[]
|
||
|
|
|
||
|
|
== How to fix it
|
||
|
|
|
||
|
|
=== Code examples
|
||
|
|
|
||
|
|
==== Noncompliant code example
|
||
|
|
|
||
|
|
[source,go,diff-id=1,diff-type=noncompliant]
|
||
|
|
----
|
||
|
|
import (
|
||
|
|
"crypto/cipher"
|
||
|
|
)
|
||
|
|
|
||
|
|
func encrypt(block cipher.Block, plaintext []byte) {
|
||
|
|
iv := []byte("fixed IVfixed IV")
|
||
|
|
encrypter := cipher.NewCBCEncrypter(block, iv) // Noncompliant
|
||
|
|
encrypter.CryptBlocks(plaintext, plaintext)
|
||
|
|
}
|
||
|
|
----
|
||
|
|
|
||
|
|
==== Compliant solution
|
||
|
|
|
||
|
|
include::../common/fix/explicit-fix.adoc[]
|
||
|
|
|
||
|
|
[source,go,diff-id=1,diff-type=compliant]
|
||
|
|
----
|
||
|
|
import (
|
||
|
|
"crypto/cipher"
|
||
|
|
"crypto/rand"
|
||
|
|
)
|
||
|
|
|
||
|
|
func encrypt(block cipher.Block, plaintext []byte) {
|
||
|
|
iv := make([]byte, block.BlockSize())
|
||
|
|
rand.Read(iv)
|
||
|
|
encrypter := cipher.NewCBCEncrypter(block, iv)
|
||
|
|
encrypter.CryptBlocks(plaintext, plaintext)
|
||
|
|
}
|
||
|
|
----
|
||
|
|
|
||
|
|
=== How does this work?
|
||
|
|
|
||
|
|
include::../common/fix/fix.adoc[]
|
||
|
|
|
||
|
|
|
||
|
|
|
||
|
|
== Resources
|
||
|
|
|
||
|
|
include::../common/resources/docs.adoc[]
|
||
|
|
|
||
|
|
include::../common/resources/articles.adoc[]
|
||
|
|
|
||
|
|
include::../common/resources/presentations.adoc[]
|
||
|
|
|
||
|
|
include::../common/resources/standards.adoc[]
|
||
|
|
|
||
|
|
ifdef::env-github,rspecator-view[]
|
||
|
|
|
||
|
|
'''
|
||
|
|
== Implementation Specification
|
||
|
|
(visible only on this page)
|
||
|
|
|
||
|
|
include::../message.adoc[]
|
||
|
|
|
||
|
|
'''
|
||
|
|
|
||
|
|
endif::env-github,rspecator-view[]
|
||
|
|
|