53 lines
1.4 KiB
Plaintext
Raw Permalink Normal View History

== Why is this an issue?
2020-06-30 12:47:33 +02:00
Using the same value on either side of a binary operator is almost always a mistake. In the case of logical operators, it is either a copy/paste error and therefore a bug, or it is simply wasted code, and should be simplified. In the case of bitwise operators and most binary mathematical operators, having the same value on both sides of an operator yields predictable results, and should be simplified.
2021-02-02 15:02:10 +01:00
2021-01-27 13:42:22 +01:00
Note that this rule will raise issues on ``++a == a++`` and ``++a != a++`` expressions which are sometime used to detect ``++NaN++`` values. It is recommended to use instead https://docs.python.org/3/library/math.html#math.isnan[``++math.isnan++``] or an equivalent function. This will improve code readability.
2020-06-30 12:47:33 +02:00
=== Noncompliant code example
2020-06-30 12:47:33 +02:00
2022-02-04 17:28:24 +01:00
[source,python]
2020-06-30 12:47:33 +02:00
----
if a == a: # Noncompliant
work()
if a != a: # Noncompliant
work()
if a == b and a == b: # Noncompliant
work()
if a == b or a == b: # Noncompliant
work()
j = 5 / 5 # Noncompliant
k = 5 - 5 # Noncompliant
----
=== Exceptions
2020-06-30 12:47:33 +02:00
The following are ignored:
2021-01-27 13:42:22 +01:00
* The expression ``++1 << 1++``
2020-06-30 12:47:33 +02:00
include::../see.adoc[]
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
include::../message.adoc[]
include::../highlighting.adoc[]
'''
== Comments And Links
(visible only on this page)
include::../comments-and-links.adoc[]
endif::env-github,rspecator-view[]