rspec/rules/S2792/java/rule.adoc

56 lines
1.3 KiB
Plaintext
Raw Permalink Normal View History

== Why is this an issue?
2021-04-28 16:49:39 +02:00
According to the JDBC specification:
____
``++Blob++``, ``++Clob++``, and ``++NClob++`` Java objects remain valid for at least the duration of the transaction in which they are created. This could potentially result in an application running out of resources during a long running transaction.
____
=== Noncompliant code example
2021-04-28 16:49:39 +02:00
2022-02-04 17:28:24 +01:00
[source,java]
2021-04-28 16:49:39 +02:00
----
PreparedStatement ps = conn.prepareStatement("SELECT text, img from photos where author=?");
ps.setString(1,author);
ResultSet rs = ps.executeQuery();
while (rs.next()) {
Image image = saveImg(rs.getBlob("img").getBinaryStream()); // Noncompliant; blob is never freed
image.addCaption(rs.getClob("text").getCharacterStream()); // Noncompliant
}
----
=== Compliant solution
2021-04-28 16:49:39 +02:00
2022-02-04 17:28:24 +01:00
[source,java]
2021-04-28 16:49:39 +02:00
----
PreparedStatement ps = conn.prepareStatement("SELECT text, img from photos where author=?");
ps.setString(1,author);
ResultSet rs = ps.executeQuery();
while (rs.next()) {
Blob blob = rs.getBlob("img");
Image image = saveImg(blob.getBinaryStream());
blob.free();
Clob clob = rs.getClob("text");
image.addCaption(clob.getCharacterStream());
clob.free();
}
----
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
=== Message
* Add a "xxx.free()" call.
* Free the "xxx" retrieved on this line.
endif::env-github,rspecator-view[]