2023-05-03 11:06:20 +02:00
== Why is this an issue?
2021-04-28 16:49:39 +02:00
According to the JDBC specification:
____
``++Blob++``, ``++Clob++``, and ``++NClob++`` Java objects remain valid for at least the duration of the transaction in which they are created. This could potentially result in an application running out of resources during a long running transaction.
____
2021-04-28 18:08:03 +02:00
2023-05-03 11:06:20 +02:00
=== Noncompliant code example
2021-04-28 16:49:39 +02:00
2022-02-04 17:28:24 +01:00
[source,java]
2021-04-28 16:49:39 +02:00
----
PreparedStatement ps = conn.prepareStatement("SELECT text, img from photos where author=?");
ps.setString(1,author);
ResultSet rs = ps.executeQuery();
while (rs.next()) {
Image image = saveImg(rs.getBlob("img").getBinaryStream()); // Noncompliant; blob is never freed
image.addCaption(rs.getClob("text").getCharacterStream()); // Noncompliant
}
----
2021-04-28 18:08:03 +02:00
2023-05-03 11:06:20 +02:00
=== Compliant solution
2021-04-28 16:49:39 +02:00
2022-02-04 17:28:24 +01:00
[source,java]
2021-04-28 16:49:39 +02:00
----
PreparedStatement ps = conn.prepareStatement("SELECT text, img from photos where author=?");
ps.setString(1,author);
ResultSet rs = ps.executeQuery();
while (rs.next()) {
Blob blob = rs.getBlob("img");
Image image = saveImg(blob.getBinaryStream());
blob.free();
Clob clob = rs.getClob("text");
image.addCaption(clob.getCharacterStream());
clob.free();
}
----
2021-04-28 18:08:03 +02:00
2021-09-20 15:38:42 +02:00
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
2023-05-25 14:18:12 +02:00
=== Message
* Add a "xxx.free()" call.
* Free the "xxx" retrieved on this line.
2021-09-20 15:38:42 +02:00
endif::env-github,rspecator-view[]