rspec/rules/S2798/rpg/rule.adoc

46 lines
1.1 KiB
Plaintext
Raw Permalink Normal View History

== Why is this an issue?
2021-04-28 16:49:39 +02:00
Having all the pieces in front of you makes it easier to understand and debug or maintain a piece of code. Unfortunately, that's often not the case with compile-time arrays, since they are often separated from the code that uses them by many, many lines. Instead, data structures are often a better option.
=== Noncompliant code example
2021-04-28 16:49:39 +02:00
2022-02-04 17:28:24 +01:00
[source,rpg]
2021-04-28 16:49:39 +02:00
----
D directions S 5 0 dim(4) ctdata perrcd(1)
----
=== Compliant solution
2021-04-28 16:49:39 +02:00
2022-02-04 17:28:24 +01:00
[source,rpg]
2021-04-28 16:49:39 +02:00
----
D dirData DS
D 5 Inz('North')
D 5 Inz('South')
D 5 Inz('East')
D 5 Inz('West')
D directions 5 Dim(4) Overlay(dirData)
----
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
=== Message
Move this array into a data structure
'''
== Comments And Links
(visible only on this page)
=== on 2 Apr 2015, 19:03:30 Ann Campbell wrote:
http://www.bmeyers.net/faqs/14-tips/32-rpg-iv-style?start=3
endif::env-github,rspecator-view[]