rspec/rules/S3981/php/rule.adoc

41 lines
996 B
Plaintext
Raw Permalink Normal View History

== Why is this an issue?
2023-05-29 18:37:58 +02:00
The count of elements from an array or Countable object is always greater than or equal to zero. Testing it doesn't make sense, since the result is always ``++true++``.
2020-06-30 12:48:39 +02:00
2022-02-04 17:28:24 +01:00
[source,php]
2020-06-30 12:48:39 +02:00
----
2023-05-29 18:37:58 +02:00
if (count($arr) >= 0) {...} // Noncompliant: always true
2020-06-30 12:48:39 +02:00
2023-05-29 18:37:58 +02:00
$result = count($arr) >= 0; // Noncompliant always true
2020-06-30 12:48:39 +02:00
----
2023-05-29 18:37:58 +02:00
Similarly testing that it is less than zero will always return ``++false++``.
2020-06-30 12:48:39 +02:00
2022-02-04 17:28:24 +01:00
[source,php]
2020-06-30 12:48:39 +02:00
----
2023-05-29 18:37:58 +02:00
if (count($arr) < 0) {...} // Noncompliant: always false
2020-06-30 12:48:39 +02:00
----
2023-05-29 18:37:58 +02:00
Fix the code to properly check for emptiness if it was the intent, or remove the redundant code to keep the current behavior.
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
=== Message
The count of an array or Countable is always ">=0", so update this test to either "==0" or ">0".
include::../highlighting.adoc[]
'''
== Comments And Links
(visible only on this page)
include::../comments-and-links.adoc[]
endif::env-github,rspecator-view[]