2023-05-03 11:06:20 +02:00
|
|
|
== Why is this an issue?
|
|
|
|
|
2020-12-21 15:38:52 +01:00
|
|
|
Assertions comparing an object to itself are more likely to be bugs due to developer's carelessness.
|
|
|
|
|
2021-02-02 15:02:10 +01:00
|
|
|
|
2020-12-21 15:38:52 +01:00
|
|
|
This rule raises an issue when the actual expression matches the expected expression.
|
|
|
|
|
2023-05-03 11:06:20 +02:00
|
|
|
=== Noncompliant code example
|
2020-12-21 15:38:52 +01:00
|
|
|
|
2022-02-04 17:28:24 +01:00
|
|
|
[source,php]
|
2020-12-21 15:38:52 +01:00
|
|
|
----
|
|
|
|
assertEqual($a, $a); // Noncompliant
|
|
|
|
assertSame($a, $a); // Noncompliant
|
|
|
|
assertNotEqual($a, $a); // Noncompliant
|
|
|
|
assertNotSame($a, $a); // Noncompliant
|
|
|
|
----
|
|
|
|
|
2023-05-03 11:06:20 +02:00
|
|
|
=== Compliant solution
|
2020-12-21 15:38:52 +01:00
|
|
|
|
2022-02-04 17:28:24 +01:00
|
|
|
[source,php]
|
2020-12-21 15:38:52 +01:00
|
|
|
----
|
|
|
|
assertEqual($expected, $a);
|
|
|
|
assertSame($expected, $a);
|
|
|
|
assertNotEqual($expected, $a);
|
|
|
|
assertNotSame($expected, $a);
|
|
|
|
----
|
2021-06-02 20:44:38 +02:00
|
|
|
|
2021-06-03 09:05:38 +02:00
|
|
|
ifdef::env-github,rspecator-view[]
|
2021-09-20 15:38:42 +02:00
|
|
|
|
|
|
|
'''
|
|
|
|
== Implementation Specification
|
|
|
|
(visible only on this page)
|
|
|
|
|
2023-05-25 14:18:12 +02:00
|
|
|
=== Message
|
|
|
|
|
|
|
|
Replace this assertion to not have the same actual and expected expression.
|
|
|
|
|
|
|
|
|
|
|
|
=== Highlighting
|
|
|
|
|
|
|
|
Primary: expected expression
|
|
|
|
|
|
|
|
|
|
|
|
Secondary: actual expression
|
2021-09-20 15:38:42 +02:00
|
|
|
|
|
|
|
|
2021-06-08 15:52:13 +02:00
|
|
|
'''
|
2021-06-02 20:44:38 +02:00
|
|
|
== Comments And Links
|
|
|
|
(visible only on this page)
|
|
|
|
|
|
|
|
include::../comments-and-links.adoc[]
|
2023-06-22 10:38:01 +02:00
|
|
|
|
2021-06-03 09:05:38 +02:00
|
|
|
endif::env-github,rspecator-view[]
|