rspec/rules/S5863/php/rule.adoc

54 lines
988 B
Plaintext
Raw Permalink Normal View History

== Why is this an issue?
Assertions comparing an object to itself are more likely to be bugs due to developer's carelessness.
2021-02-02 15:02:10 +01:00
This rule raises an issue when the actual expression matches the expected expression.
=== Noncompliant code example
2022-02-04 17:28:24 +01:00
[source,php]
----
assertEqual($a, $a); // Noncompliant
assertSame($a, $a); // Noncompliant
assertNotEqual($a, $a); // Noncompliant
assertNotSame($a, $a); // Noncompliant
----
=== Compliant solution
2022-02-04 17:28:24 +01:00
[source,php]
----
assertEqual($expected, $a);
assertSame($expected, $a);
assertNotEqual($expected, $a);
assertNotSame($expected, $a);
----
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
=== Message
Replace this assertion to not have the same actual and expected expression.
=== Highlighting
Primary: expected expression
Secondary: actual expression
'''
== Comments And Links
(visible only on this page)
include::../comments-and-links.adoc[]
endif::env-github,rspecator-view[]