rspec/rules/S1950/flex/rule.adoc

55 lines
1.0 KiB
Plaintext
Raw Normal View History

2021-04-28 16:49:39 +02:00
Having multiple cases in a ``++switch++`` with the same condition is confusing at best. At worst, it's a bug that is likely to induce further bugs as the code is maintained.
If the first case ends with a break, the second case will never be executed, rendering it dead code. Worse there is the risk in this situation that future maintenance will be done on the dead case, rather than on the one that's actually used.
On the other hand, if the first case does not end with a break, both cases will be executed, but future maintainers may not notice that.
2021-04-28 16:49:39 +02:00
== Noncompliant Code Example
----
switch(i) {
case 1:
//...
break;
case 5:
//...
break;
case 3:
//...
break;
case 1: // Noncompliant
//...
break;
}
----
2021-04-28 16:49:39 +02:00
== Compliant Solution
----
switch(i) {
case 1:
//...
break;
case 5:
//...
break;
case 3:
//...
break;
}
----
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
include::message.adoc[]
endif::env-github,rspecator-view[]