2021-01-23 04:07:47 +00:00
In Unix, "others" class refers to all users except the owner of the file and the members of the group assigned to this file.
In Windows, "Everyone" group is similar and includes all members of the Authenticated Users group as well as the built-in Guest account, and several other built-in security accounts.
2021-01-22 04:06:24 +00:00
Granting permissions to these groups can lead to unintended access to files.
include::../ask-yourself.adoc[]
include::../recommended.adoc[]
== Sensitive Code Example
.Net Framework:
----
var unsafeAccessRule = new FileSystemAccessRule("Everyone", FileSystemRights.FullControl, AccessControlType.Allow);
var fileSecurity = File.GetAccessControl("path");
fileSecurity.AddAccessRule(unsafeAccessRule); // Noncompliant
fileSecurity.SetAccessRule(unsafeAccessRule); // Noncompliant
File.SetAccessControl("fileName", fileSecurity);
----
.Net / .Net Core
----
var fileInfo = new FileInfo("path");
var fileSecurity = fileInfo.GetAccessControl();
fileSecurity.AddAccessRule(new FileSystemAccessRule("Everyone", FileSystemRights.Write, AccessControlType.Allow)); // Noncompliant
fileInfo.SetAccessControl(fileSecurity);
----
.Net / .Net Core using Mono.Posix.NETStandard
----
var fileSystemEntry = UnixFileSystemInfo.GetFileSystemEntry("path");
fileSystemEntry.FileAccessPermissions = FileAccessPermissions.OtherReadWriteExecute; // Noncompliant
----
== Compliant Solution
2021-01-23 04:07:47 +00:00
.Net Framework
----
var safeAccessRule = new FileSystemAccessRule("Everyone", FileSystemRights.FullControl, AccessControlType.Deny);
var fileSecurity = File.GetAccessControl("path");
fileSecurity.AddAccessRule(safeAccessRule);
File.SetAccessControl("path", fileSecurity);
----
.Net / .Net Core
2021-01-22 04:06:24 +00:00
----
var safeAccessRule = new FileSystemAccessRule("Everyone", FileSystemRights.FullControl, AccessControlType.Deny);
var fileInfo = new FileInfo("path");
var fileSecurity = fileInfo.GetAccessControl();
fileSecurity.SetAccessRule(safeAccessRule);
fileInfo.SetAccessControl(fileSecurity);
----
2021-01-23 04:07:47 +00:00
.Net / .Net Core using Mono.Posix.NETStandard
2021-01-22 04:06:24 +00:00
----
var fs = UnixFileSystemInfo.GetFileSystemEntry("path");
fs.FileAccessPermissions = FileAccessPermissions.UserExecute;
----
include::../see.adoc[]