rspec/frontend/src/RulePage.tsx

326 lines
9.5 KiB
TypeScript
Raw Normal View History

import React from 'react';
2020-07-09 18:53:51 +02:00
import { makeStyles } from '@material-ui/core/styles';
import Container from '@material-ui/core/Container';
import Typography from '@material-ui/core/Typography';
import Tabs from '@material-ui/core/Tabs';
import Tab from '@material-ui/core/Tab';
2020-07-09 18:53:51 +02:00
import Box from '@material-ui/core/Box';
import { Link } from '@material-ui/core';
import { Link as RouterLink } from 'react-router-dom';
2020-07-09 18:53:51 +02:00
import Highlight from 'react-highlight';
import { useHistory } from 'react-router-dom';
2020-07-09 18:53:51 +02:00
import { useRuleCoverage } from './utils/useRuleCoverage';
import { useFetch } from './utils/useFetch';
2021-01-26 22:10:28 +01:00
import { RuleMetadata } from './types';
2020-07-09 18:53:51 +02:00
import './hljs-humanoid-light.css';
const useStyles = makeStyles((theme) => ({
2020-07-09 18:53:51 +02:00
ruleBar: {
borderBottom: '1px solid lightgrey',
},
ruleid: {
textAlign: 'center',
marginTop: theme.spacing(3),
marginBottom: theme.spacing(3),
},
ruleidLink: {
color: 'inherit',
},
2020-07-09 18:53:51 +02:00
title: {
textAlign: 'justify',
marginTop: theme.spacing(4),
marginBottom: theme.spacing(4),
},
coverage: {
marginBottom: theme.spacing(3),
},
description: {
2020-07-09 18:53:51 +02:00
textAlign: 'justify',
// marginBottom: theme.spacing(3),
},
2020-07-09 18:53:51 +02:00
// style used to center the tabs when there too few of them to fill the container
tabRoot: {
justifyContent: "center"
},
2020-07-09 18:53:51 +02:00
tabScroller: {
2021-01-26 22:10:28 +01:00
flexGrow: 0
},
unimplemented: {
color: 'red'
},
tab: {
display: 'flex',
"&::before": {
content: '""',
display: 'block',
width: theme.spacing(1),
height: theme.spacing(1),
marginRight: theme.spacing(1),
borderRadius: theme.spacing(1),
},
'& > .MuiTab-wrapper': {
width: 'auto',
}
},
tabCovered: {
"&::before": {
backgroundColor: '#4c9bd6',
}
},
tabTargeted: {
"&::before": {
backgroundColor: '#fd6a00',
}
},
}));
2021-01-26 22:10:28 +01:00
const languageToJiraProject = new Map(Object.entries({
"PYTHON": "SONARPY",
"ABAP": "SONARABAP",
"CFAMILY": "CPP",
"JAVA": "SONARJAVA",
"COBOL": "SONARCOBOL",
"FLEX": "SONARFLEX",
"HTML": "SONARHTML",
"PHP": "SONARPHP",
"PLI": "SONARPLI",
"PLSQL": "SONARPLSQL",
"RPG": "SONARRPG",
"APEX": "SONARSLANG",
"RUBY": "SONARSLANG",
"KOTLIN": "SONARKT",
"SCALA": "SONARSLANG",
"GO": "SONARSLANG",
"SECRETS": "SECRETS",
"SWIFT": "SONARSWIFT",
"TSQL": "SONARTSQL",
"VB6": "SONARVBSIX",
"XML": "SONARXML",
"CLOUDFORMATION": "SONARIAC",
"TERRAFORM": "SONARIAC",
2021-01-26 22:10:28 +01:00
}));
2021-01-26 22:10:28 +01:00
const languageToGithubProject = new Map(Object.entries({
"ABAP": "sonar-abap",
"CSHARP": "sonar-dotnet",
"VBNET": "sonar-dotnet",
"JAVASCRIPT": "SonarJS",
"TYPESCRIPT": "SonarJS",
"SWIFT": "sonar-swift",
"KOTLIN": "sonar-kotlin",
"GO": "slang-enterprise",
"SCALA": "slang-enterprise",
"RUBY": "slang-enterprise",
"APEX": "slang-enterprise",
"HTML": "sonar-html",
"COBOL": "sonar-cobol",
"VB6": "sonar-vb",
"JAVA": "sonar-java",
"PLI": "sonar-pli",
"CFAMILY": "sonar-cpp",
"CSS": "sonar-css",
"FLEX": "sonar-flex",
"PHP": "sonar-php",
"PLSQL": "sonar-plsql",
"PYTHON": "sonar-python",
"RPG": "sonar-rpg",
"TSQL": "sonar-tsql",
"XML": "sonar-xml",
"CLOUDFORMATION": "sonar-iac",
"TERRAFORM": "sonar-iac",
"SECRETS": "sonar-secrets",
2021-01-26 22:10:28 +01:00
}));
function ticketsAndImplementationPRsLinks(ruleNumber: string, title: string, language?: string) {
if (language) {
const upperCaseLanguage = language.toUpperCase();
const jiraProject = languageToJiraProject.get(upperCaseLanguage);
const githubProject = languageToGithubProject.get(upperCaseLanguage);
const titleWihoutQuotes = title.replaceAll('"','');
const implementationPRsLink = (
<Link href={`https://github.com/SonarSource/${githubProject}/pulls?q=is%3Apr+"S${ruleNumber}"+OR+"RSPEC-${ruleNumber}"`}>
Implementation Pull Requests
</Link>
);
if (jiraProject !== undefined) {
const ticketsLink = (
<Link href={`https://jira.sonarsource.com/issues/?jql=project%20%3D%20${jiraProject}%20AND%20(text%20~%20%22S${ruleNumber}%22%20OR%20text%20~%20%22RSPEC-${ruleNumber}%22%20OR%20text%20~%20"${titleWihoutQuotes}")`}>
Implementation tickets on Jira
</Link>
);
return {ticketsLink, implementationPRsLink};
} else {
const ticketsLink = (
<Link href={`https://github.com/SonarSource/${githubProject}/issues?q=is%3Aissue+"S${ruleNumber}"+OR+"RSPEC-${ruleNumber}"`}>
Implementation issues on GitHub
</Link>
);
return {ticketsLink, implementationPRsLink};
}
} else {
const ticketsLink = (<div>Select a language to see the implementation tickets</div>);
const implementationPRsLink = (<div>Select a language to see the implementation pull requests</div>);
return {ticketsLink, implementationPRsLink};
}
}
2021-01-26 22:10:28 +01:00
export function RulePage(props: any) {
const ruleid = props.match.params.ruleid;
// language can be absent
const language = props.match.params.language;
document.title = ruleid;
const history = useHistory();
2021-01-26 22:10:28 +01:00
function handleLanguageChange(event: any, lang: string) {
history.push(`/${ruleid}/${lang}`);
}
const classes = useStyles();
let branch = 'master'
let descUrl = process.env.PUBLIC_URL + '/rules/' + ruleid + "/" + (language ?? "default") + "-description.html";
let metadataUrl = process.env.PUBLIC_URL + '/rules/' + ruleid + "/" + (language ?? "default") + "-metadata.json";
2021-01-26 22:10:28 +01:00
let [descHTML, descError, descIsLoading] = useFetch<string>(descUrl, false);
let [metadataJSON, metadataError, metadataIsLoading] = useFetch<RuleMetadata>(metadataUrl);
const {ruleCoverage, allLangsRuleCoverage, isLanguageCovered} = useRuleCoverage();
2021-01-26 22:10:28 +01:00
let coverage: any = "Loading...";
2020-07-09 18:53:51 +02:00
let title = "Loading..."
2020-07-06 11:03:32 +02:00
let metadataJSONString;
let languagesTabs = null;
let prUrl: string | undefined = undefined;
2021-01-26 22:10:28 +01:00
if (metadataJSON && !metadataIsLoading && !metadataError) {
title = metadataJSON.title;
if ('prUrl' in metadataJSON) {
prUrl = metadataJSON.prUrl;
}
branch = metadataJSON.branch;
metadataJSON.all_languages.sort();
languagesTabs = metadataJSON.all_languages.map(lang => {
const isImplemented = isLanguageCovered(lang, metadataJSON!.allKeys);
const classNames = classes.tab + ' ' + (isImplemented ? classes.tabCovered : classes.tabTargeted);
return <Tab label={lang} value={lang} className={classNames} />;
});
2020-07-06 11:03:32 +02:00
metadataJSONString = JSON.stringify(metadataJSON, null, 2);
2020-07-09 18:53:51 +02:00
const coverageMapper = (key: any, range: any) => {
if (typeof range === "string") {
return (
<li >{key}: {range}</li>
);
} else {
return (
<li>Not covered for {key} anymore. Was covered from {range['since']} to {range['until']}.</li>
);
}
};
if (language) {
coverage = ruleCoverage(language, metadataJSON.allKeys, coverageMapper);
} else {
coverage = allLangsRuleCoverage(metadataJSON.allKeys, coverageMapper);
}
}
if (coverage !== "Not Covered") {
prUrl = undefined;
branch = 'master';
}
let editOnGithubUrl = 'https://github.com/SonarSource/rspec/blob/' +
branch + '/rules/' + ruleid + (language ? '/' + language : '');
let description = <div>Loading...</div>;
2021-01-26 22:10:28 +01:00
if (descHTML !== null && !descIsLoading && !descError) {
2020-07-06 11:03:32 +02:00
description = <div>
<div dangerouslySetInnerHTML={{__html: descHTML}}/>
<hr />
<a href={editOnGithubUrl}>Edit on Github</a><br/>
<hr />
<Highlight className='json'>{metadataJSONString}</Highlight>
2020-07-06 11:03:32 +02:00
</div>;
}
let prLink = <></>;
if (prUrl) {
prLink = <div><span className={classes.unimplemented}>Not implemented (see <a href={prUrl}>PR</a>)</span></div>
}
const ruleNumber = ruleid.substring(1);
const specificationPRsLink = (
<Link href={`https://github.com/SonarSource/rspec/pulls?q=is%3Apr+"S${ruleNumber}"+OR+"RSPEC-${ruleNumber}"`}>
Specification Pull Requests
</Link>
);
const {ticketsLink, implementationPRsLink} = ticketsAndImplementationPRsLinks(ruleNumber, title, language);
const tabsValue = language ? {'value' : language} : {'value': false};
2020-07-09 18:53:51 +02:00
return (
<div>
2020-07-09 18:53:51 +02:00
<div className={classes.ruleBar}>
<Container>
<Typography variant="h2" classes={{root: classes.ruleid}}>
<Link className={classes.ruleidLink} component={RouterLink} to={`/${ruleid}`} underline="none">{ruleid}</Link>
</Typography>
<Typography variant="h4" classes={{root: classes.ruleid}}>{prLink}</Typography>
<Tabs
{...tabsValue}
onChange={handleLanguageChange}
indicatorColor="primary"
textColor="primary"
centered
variant="scrollable"
scrollButtons="auto"
classes={{ root: classes.tabRoot, scroller: classes.tabScroller }}
>
{languagesTabs}
</Tabs>
2020-07-09 18:53:51 +02:00
</Container>
</div>
<Container maxWidth="md">
2020-07-09 18:53:51 +02:00
<Typography variant="h3" classes={{root: classes.title}}>{title}</Typography>
2021-01-26 22:10:28 +01:00
<Box className={classes.coverage}>
2020-07-09 18:53:51 +02:00
<Typography variant="h4" >Covered Since</Typography>
<ul>
{coverage}
</ul>
</Box>
2021-01-26 22:10:28 +01:00
<Box className={classes.coverage}>
<Typography variant="h4" >Related Tickets and Pull Requests</Typography>
<ul>
{specificationPRsLink}
</ul>
<ul>
{implementationPRsLink}
</ul>
<ul>
{ticketsLink}
</ul>
</Box>
2021-01-26 22:10:28 +01:00
<Box>
2020-07-09 18:53:51 +02:00
<Typography variant="h4">Description</Typography>
<Typography className={classes.description}>
{description}
</Typography>
</Box>
</Container>
</div>
);
2020-07-06 11:03:32 +02:00
}