rspec/rules/S3415/php/rule.adoc

39 lines
1.1 KiB
Plaintext
Raw Normal View History

== Why is this an issue?
2021-01-27 13:42:22 +01:00
The standard PHPUnit assertion methods such as _``++assertEquals++``_, expect the first argument to be the expected value and the second argument to be the actual value. Swap them, and your test will still have the same outcome (succeed/fail when it should) but the error messages will be confusing.
2021-02-02 15:02:10 +01:00
This rule raises an issue when the second argument to an assertions library method is a hard-coded value and the first argument is not.
=== Noncompliant code example
2022-02-04 17:28:24 +01:00
[source,php]
----
self::assertEquals($runner.getExitCode(), 0, "Unexpected exit code"); // Noncompliant; Failed asserting that 0 matches expected 3. Expected :3 Actual :0.
----
=== Compliant solution
2022-02-04 17:28:24 +01:00
[source,php]
----
self::assertEquals(0, $runner.getExitCode(), "Unexpected exit code");
----
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
include::../message.adoc[]
include::../highlighting.adoc[]
'''
== Comments And Links
(visible only on this page)
include::../comments-and-links.adoc[]
endif::env-github,rspecator-view[]