rspec/rules/S3923/vbnet/rule.adoc

62 lines
1.2 KiB
Plaintext
Raw Normal View History

== Why is this an issue?
Having all branches of a `Select Case` or `If` chain with the same implementation indicates a problem.
2020-06-30 12:48:39 +02:00
In the following code:
2020-06-30 12:48:39 +02:00
2022-02-04 17:28:24 +01:00
[source,vbnet]
2020-06-30 12:48:39 +02:00
----
Dim b As Integer = If(a > 12, 4, 4) // Noncompliant
2020-06-30 12:48:39 +02:00
If b = 0 Then // Noncompliant
2020-06-30 12:48:39 +02:00
DoTheThing()
Else
DoTheThing()
End If
Select Case i // Noncompliant
2020-06-30 12:48:39 +02:00
Case 1
DoSomething()
Case 2
DoSomething()
Case 3
DoSomething()
Case Else
DoSomething()
End Select
----
Either there is a copy-paste error that needs fixing or an unnecessary `Select Case` or `If` chain that needs removing.
=== Exceptions
2020-06-30 12:48:39 +02:00
This rule does not apply to `If` chains without `Else`, nor to `Select Case` without a `Case Else` clause.
2020-06-30 12:48:39 +02:00
2021-02-02 15:02:10 +01:00
[source,vbnet]
2020-06-30 12:48:39 +02:00
----
If b = 0 Then ' No issue, this could have been done on purpose to make the code more readable
DoTheThing()
ElseIf
DoTheThing()
End If
----
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
include::../message.adoc[]
include::../highlighting.adoc[]
'''
== Comments And Links
(visible only on this page)
include::../comments-and-links.adoc[]
endif::env-github,rspecator-view[]