2023-05-03 11:06:20 +02:00
|
|
|
== Why is this an issue?
|
|
|
|
|
2023-06-08 17:06:21 +02:00
|
|
|
Having all branches of a `Select Case` or `If` chain with the same implementation indicates a problem.
|
2020-06-30 12:48:39 +02:00
|
|
|
|
2023-06-08 17:06:21 +02:00
|
|
|
In the following code:
|
2020-06-30 12:48:39 +02:00
|
|
|
|
2022-02-04 17:28:24 +01:00
|
|
|
[source,vbnet]
|
2020-06-30 12:48:39 +02:00
|
|
|
----
|
2023-06-08 17:06:21 +02:00
|
|
|
Dim b As Integer = If(a > 12, 4, 4) // Noncompliant
|
2020-06-30 12:48:39 +02:00
|
|
|
|
2023-06-08 17:06:21 +02:00
|
|
|
If b = 0 Then // Noncompliant
|
2020-06-30 12:48:39 +02:00
|
|
|
DoTheThing()
|
|
|
|
Else
|
|
|
|
DoTheThing()
|
|
|
|
End If
|
|
|
|
|
2023-06-08 17:06:21 +02:00
|
|
|
Select Case i // Noncompliant
|
2020-06-30 12:48:39 +02:00
|
|
|
Case 1
|
|
|
|
DoSomething()
|
|
|
|
Case 2
|
|
|
|
DoSomething()
|
|
|
|
Case 3
|
|
|
|
DoSomething()
|
|
|
|
Case Else
|
|
|
|
DoSomething()
|
|
|
|
End Select
|
|
|
|
----
|
|
|
|
|
2023-06-08 17:06:21 +02:00
|
|
|
Either there is a copy-paste error that needs fixing or an unnecessary `Select Case` or `If` chain that needs removing.
|
|
|
|
|
2023-05-03 11:06:20 +02:00
|
|
|
=== Exceptions
|
2020-06-30 12:48:39 +02:00
|
|
|
|
2023-06-08 17:06:21 +02:00
|
|
|
This rule does not apply to `If` chains without `Else`, nor to `Select Case` without a `Case Else` clause.
|
2020-06-30 12:48:39 +02:00
|
|
|
|
2021-02-02 15:02:10 +01:00
|
|
|
|
2023-05-25 14:18:12 +02:00
|
|
|
[source,vbnet]
|
2020-06-30 12:48:39 +02:00
|
|
|
----
|
|
|
|
If b = 0 Then ' No issue, this could have been done on purpose to make the code more readable
|
|
|
|
DoTheThing()
|
|
|
|
ElseIf
|
|
|
|
DoTheThing()
|
|
|
|
End If
|
|
|
|
----
|
2021-06-02 20:44:38 +02:00
|
|
|
|
2021-06-03 09:05:38 +02:00
|
|
|
ifdef::env-github,rspecator-view[]
|
2021-09-20 15:38:42 +02:00
|
|
|
|
|
|
|
'''
|
|
|
|
== Implementation Specification
|
|
|
|
(visible only on this page)
|
|
|
|
|
|
|
|
include::../message.adoc[]
|
|
|
|
|
|
|
|
include::../highlighting.adoc[]
|
|
|
|
|
2021-06-08 15:52:13 +02:00
|
|
|
'''
|
2021-06-02 20:44:38 +02:00
|
|
|
== Comments And Links
|
|
|
|
(visible only on this page)
|
|
|
|
|
|
|
|
include::../comments-and-links.adoc[]
|
2023-06-22 10:38:01 +02:00
|
|
|
|
2021-06-03 09:05:38 +02:00
|
|
|
endif::env-github,rspecator-view[]
|