rspec/rules/S4524/abap/rule.adoc

49 lines
1.2 KiB
Plaintext
Raw Normal View History

== Why is this an issue?
2021-01-27 13:42:22 +01:00
``++CASE++`` can contain a ``++WHEN OTHERS++`` clause for various reasons: to handle unexpected values, to show that all the cases were properly considered.
2021-02-02 15:02:10 +01:00
2021-01-27 13:42:22 +01:00
For readability purpose, to help a developer to quickly find the default behavior of a ``++CASE++`` statement, it is recommended to put the ``++WHEN OTHERS++`` clause at the end of the ``++CASE++`` statement. This rule raises an issue if the ``++WHEN OTHERS++`` clause is not the last one of the ``++CASE++``'s cases.
2020-06-30 12:49:37 +02:00
=== Noncompliant code example
2020-06-30 12:49:37 +02:00
2022-02-04 17:28:24 +01:00
[source,abap]
2020-06-30 12:49:37 +02:00
----
CASE SY-INDEX.
WHEN OTHERS. // Noncompliant; WHEN OTHERS should be last statement
WRITE 'Unexpected result'
WHEN ONE.
WRITE 'One'.
WHEN 2.
WRITE 'Two'.
ENDCASE.
----
=== Compliant solution
2020-06-30 12:49:37 +02:00
2022-02-04 17:28:24 +01:00
[source,abap]
2020-06-30 12:49:37 +02:00
----
CASE SY-INDEX.
WHEN ONE.
WRITE 'One'.
WHEN 2.
WRITE 'Two'.
WHEN OTHERS. // Compliant
WRITE 'Unexpected result'
ENDCASE.
----
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
include::../message.adoc[]
'''
== Comments And Links
(visible only on this page)
include::../comments-and-links.adoc[]
endif::env-github,rspecator-view[]