2020-06-30 12:47:33 +02:00
|
|
|
include::../description.adoc[]
|
|
|
|
|
|
|
|
== Noncompliant Code Example
|
|
|
|
|
|
|
|
----
|
|
|
|
public function func(foo:Number, bar:Number):void
|
|
|
|
{
|
|
|
|
switch (foo)
|
|
|
|
{
|
|
|
|
case 1:
|
|
|
|
// do something
|
|
|
|
break;
|
|
|
|
case 2:
|
|
|
|
switch (bar) // Noncompliant
|
|
|
|
{
|
|
|
|
case 89: // It's easy to lose sight of what's being tested; is it foo or bar?
|
|
|
|
// ...
|
|
|
|
break;
|
|
|
|
case 90:
|
|
|
|
// ...
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
case 3:
|
|
|
|
// do something
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
----
|
|
|
|
|
|
|
|
== Compliant Solution
|
|
|
|
|
|
|
|
----
|
|
|
|
public function func(foo:Number, bar:Number):void
|
|
|
|
{
|
|
|
|
switch (foo)
|
|
|
|
{
|
|
|
|
case 1:
|
|
|
|
// ...
|
|
|
|
break;
|
|
|
|
case 2:
|
|
|
|
handleBar(bar);
|
|
|
|
break;
|
|
|
|
case 3:
|
|
|
|
// ...
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
public function handleBar(bar:Number):void
|
|
|
|
{
|
|
|
|
switch (bar)
|
|
|
|
{
|
|
|
|
case 89:
|
|
|
|
// ...
|
|
|
|
break;
|
|
|
|
case 90:
|
|
|
|
// ...
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
----
|
2021-06-02 20:44:38 +02:00
|
|
|
|
2021-06-03 09:05:38 +02:00
|
|
|
ifdef::env-github,rspecator-view[]
|
2021-06-02 20:44:38 +02:00
|
|
|
== Comments And Links
|
|
|
|
(visible only on this page)
|
|
|
|
|
|
|
|
include::../comments-and-links.adoc[]
|
2021-06-03 09:05:38 +02:00
|
|
|
endif::env-github,rspecator-view[]
|