rspec/rules/S1821/ruby/rule.adoc

48 lines
971 B
Plaintext
Raw Normal View History

2021-01-27 13:42:22 +01:00
Nested ``++case++`` structures are difficult to understand because you can easily confuse the cases of an inner ``++case++`` as belonging to an outer statement. Therefore nested ``++case++`` statements should be avoided.
2020-06-30 12:47:33 +02:00
2021-02-02 15:02:10 +01:00
2021-01-27 13:42:22 +01:00
Specifically, you should structure your code to avoid the need for nested ``++case++`` statements, but if you cannot, then consider moving the inner ``++case++`` to another function.
2020-06-30 12:47:33 +02:00
== Noncompliant Code Example
----
def foo(n, m)
case n
when 0
case m # Noncompliant; nested case
when 0 then puts "0"
# ...
end
when 1 then puts "1"
else puts "2"
end
end
----
== Compliant Solution
----
def foo(n, m)
case n
when 0
bar(m)
when 1 then puts "1"
else puts "2"
end
end
def bar(m)
case m
when 0 then puts "0"
# ...
end
end
----
ifdef::env-github,rspecator-view[]
== Comments And Links
(visible only on this page)
include::../comments-and-links.adoc[]
endif::env-github,rspecator-view[]