rspec/rules/S4144/csharp/rule.adoc

64 lines
1.1 KiB
Plaintext
Raw Normal View History

== Why is this an issue?
2020-06-30 12:49:37 +02:00
When two methods have the same implementation, either it was a mistake - something else was intended - or the duplication was intentional, but may be confusing to maintainers. In the latter case, one implementation should invoke the other.
=== Noncompliant code example
2020-06-30 12:49:37 +02:00
2022-02-04 17:28:24 +01:00
[source,csharp]
2020-06-30 12:49:37 +02:00
----
private const string CODE = "bounteous";
private int callCount = 0;
public string GetCode()
{
callCount++;
return CODE;
}
public string GetName() // Noncompliant
{
callCount++;
return CODE;
}
----
=== Compliant solution
2020-06-30 12:49:37 +02:00
2022-02-04 17:28:24 +01:00
[source,csharp]
2020-06-30 12:49:37 +02:00
----
private const string CODE = "bounteous";
private int callCount = 0;
public string GetCode()
{
callCount++;
return CODE;
}
public string GetName()
{
return GetCode();
}
----
=== Exceptions
2020-06-30 12:49:37 +02:00
Empty methods, methods with only one line of code and methods with the same name (overload) are ignored.
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
include::../message.adoc[]
include::../highlighting.adoc[]
'''
== Comments And Links
(visible only on this page)
include::../comments-and-links.adoc[]
endif::env-github,rspecator-view[]