rspec/rules/S4144/kotlin/rule.adoc

62 lines
1.1 KiB
Plaintext
Raw Normal View History

== Why is this an issue?
2020-06-30 12:49:37 +02:00
When two functions have the same implementation, either it was a mistake - something else was intended - or the duplication was intentional, but may be confusing to maintainers. In the latter case, the code should be refactored.
=== Noncompliant code example
2020-06-30 12:49:37 +02:00
2022-02-04 17:28:24 +01:00
[source,kotlin]
2020-06-30 12:49:37 +02:00
----
class MyClass {
fun calculateCode(): String {
doTheThing()
doOtherThing()
return "done"
}
fun getStatus(): String { // Noncompliant
doTheThing()
doOtherThing()
return "done"
}
}
----
=== Compliant solution
2020-06-30 12:49:37 +02:00
2022-02-04 17:28:24 +01:00
[source,kotlin]
2020-06-30 12:49:37 +02:00
----
class MyClass {
fun calculateCode(): String {
doTheThing()
doOtherThing()
return "done"
}
fun getStatus(): String = calculateCode()
}
----
=== Exceptions
2020-06-30 12:49:37 +02:00
Methods with fewer than 2 statements are ignored.
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
=== Message
Update this function so that its implementation is not identical to "XXX" on line n
include::../highlighting.adoc[]
'''
== Comments And Links
(visible only on this page)
include::../comments-and-links.adoc[]
endif::env-github,rspecator-view[]