2023-05-03 11:06:20 +02:00
== Why is this an issue?
2020-06-30 12:49:37 +02:00
When two functions have the same implementation, either it was a mistake - something else was intended - or the duplication was intentional, but may be confusing to maintainers. In the latter case, the code should be refactored.
2023-05-03 11:06:20 +02:00
=== Noncompliant code example
2020-06-30 12:49:37 +02:00
2022-02-04 17:28:24 +01:00
[source,kotlin]
2020-06-30 12:49:37 +02:00
----
class MyClass {
fun calculateCode(): String {
doTheThing()
doOtherThing()
return "done"
}
fun getStatus(): String { // Noncompliant
doTheThing()
doOtherThing()
return "done"
}
}
----
2023-05-03 11:06:20 +02:00
=== Compliant solution
2020-06-30 12:49:37 +02:00
2022-02-04 17:28:24 +01:00
[source,kotlin]
2020-06-30 12:49:37 +02:00
----
class MyClass {
fun calculateCode(): String {
doTheThing()
doOtherThing()
return "done"
}
fun getStatus(): String = calculateCode()
}
----
2023-05-03 11:06:20 +02:00
=== Exceptions
2020-06-30 12:49:37 +02:00
Methods with fewer than 2 statements are ignored.
2021-06-02 20:44:38 +02:00
2021-06-03 09:05:38 +02:00
ifdef::env-github,rspecator-view[]
2021-09-20 15:38:42 +02:00
'''
== Implementation Specification
(visible only on this page)
2023-05-25 14:18:12 +02:00
=== Message
Update this function so that its implementation is not identical to "XXX" on line n
2021-09-20 15:38:42 +02:00
include::../highlighting.adoc[]
2021-06-08 15:52:13 +02:00
'''
2021-06-02 20:44:38 +02:00
== Comments And Links
(visible only on this page)
include::../comments-and-links.adoc[]
2021-06-03 09:05:38 +02:00
endif::env-github,rspecator-view[]