rspec/rules/S4524/java/rule.adoc

58 lines
1.2 KiB
Plaintext
Raw Normal View History

== Why is this an issue?
2021-01-27 13:42:22 +01:00
``++switch++`` can contain a ``++default++`` clause for various reasons: to handle unexpected values, to show that all the cases were properly considered.
2021-02-02 15:02:10 +01:00
2021-01-27 13:42:22 +01:00
For readability purpose, to help a developer to quickly find the default behavior of a ``++switch++`` statement, it is recommended to put the ``++default++`` clause at the end of the ``++switch++`` statement. This rule raises an issue if the ``++default++`` clause is not the last one of the ``++switch++``'s cases.
2020-06-30 12:49:37 +02:00
=== Noncompliant code example
2020-06-30 12:49:37 +02:00
2022-02-04 17:28:24 +01:00
[source,java]
2020-06-30 12:49:37 +02:00
----
switch (param) {
case 0:
doSomething();
break;
default: // default clause should be the last one
error();
break;
case 1:
doSomethingElse();
break;
}
----
=== Compliant solution
2020-06-30 12:49:37 +02:00
2022-02-04 17:28:24 +01:00
[source,java]
2020-06-30 12:49:37 +02:00
----
switch (param) {
case 0:
doSomething();
break;
case 1:
doSomethingElse();
break;
default:
error();
break;
}
----
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
=== Message
Move this "default" clause to the end of this "switch" statement.
'''
== Comments And Links
(visible only on this page)
include::../comments-and-links.adoc[]
endif::env-github,rspecator-view[]