rspec/rules/S4634/javascript/rule.adoc

== Why is this an issue?

When a ``++Promise++`` needs to only "resolve" or "reject", it's more efficient and readable to use the methods specially created for such use cases: ``++Promise.resolve(value)++`` and ``++Promise.reject(error)++``.


=== Noncompliant code example

[source,javascript]
----
let fulfilledPromise = new Promise(resolve => resolve(42));
let rejectedPromise = new Promise(function(resolve, reject) { 
  reject('fail');
});
----


=== Compliant solution

[source,javascript]
----
let fulfilledPromise = Promise.resolve(42);
let rejectedPromise = Promise.reject('fail');
----

ifdef::env-github,rspecator-view[]

'''
== Implementation Specification
(visible only on this page)

=== Message

Replace this trivial promise with "[Promise.resolve(XXX)|Promise.reject(XXX)]".


=== Highlighting

entire "new Promise" expression


endif::env-github,rspecator-view[]