rspec/rules/S1151/tsql/rule.adoc

69 lines
1.0 KiB
Plaintext
Raw Normal View History

== Why is this an issue?
2021-01-27 13:42:22 +01:00
As soon as a ``++WHEN++`` clause contains too much logic this highly decreases the readability of the overall expression. In such case, the content of the ``++WHEN++`` clause may be extracted into a dedicated function.
2020-06-30 12:47:33 +02:00
=== Noncompliant code example
2020-06-30 12:47:33 +02:00
With a threshold of 5:
2022-02-04 17:28:24 +01:00
[source,sql]
2020-06-30 12:47:33 +02:00
----
SELECT CASE column1
WHEN 1 THEN
CASE column2
WHEN 'a' THEN -- Noncompliant, 7 lines till ELSE
'x'
ELSE
'y'
END
ELSE
42
END
FROM table1;
----
=== Compliant solution
2020-06-30 12:47:33 +02:00
2022-02-04 17:28:24 +01:00
[source,sql]
2020-06-30 12:47:33 +02:00
----
SELECT CASE
WHEN column1 = 1 AND column2 = 'a' THEN
'x'
WHEN column1 = 1 THEN
'y'
ELSE
42
END
FROM table1;
----
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
include::../message.adoc[]
=== Parameters
.max
****
_Integer_
----
10
----
Maximum number of lines of code
****
'''
== Comments And Links
(visible only on this page)
include::../comments-and-links.adoc[]
endif::env-github,rspecator-view[]