rspec/rules/S1821/scala/rule.adoc

59 lines
1.1 KiB
Plaintext
Raw Normal View History

== Why is this an issue?
2021-01-27 13:42:22 +01:00
Nested ``++match++`` structures are difficult to understand because you can easily confuse the cases of an inner ``++match++`` as belonging to an outer statement. Therefore nested ``++match++`` statements should be avoided.
2020-06-30 12:47:33 +02:00
2021-02-02 15:02:10 +01:00
2021-01-27 13:42:22 +01:00
Specifically, you should structure your code to avoid the need for nested ``++match++`` statements, but if you cannot, then consider moving the inner ``++match++`` to another function.
2020-06-30 12:47:33 +02:00
=== Noncompliant code example
2020-06-30 12:47:33 +02:00
2022-02-04 17:28:24 +01:00
[source,scala]
2020-06-30 12:47:33 +02:00
----
def foo(n: Int, m: Int): Unit = {
n match {
case 0 => m match {
case 0 =>
// ...
}
case 1 =>
// ...
}
}
----
=== Compliant solution
2020-06-30 12:47:33 +02:00
2022-02-04 17:28:24 +01:00
[source,scala]
2020-06-30 12:47:33 +02:00
----
def foo(n: Int, m: Int): Unit = {
n match {
case 0 => bar(m)
case 1 =>
// ...
}
}
def bar(m: Int): Unit = {
m match {
case 0 =>
// ...
}
}
----
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
include::../message.adoc[]
'''
== Comments And Links
(visible only on this page)
include::../comments-and-links.adoc[]
endif::env-github,rspecator-view[]