2021-06-03 09:05:38 +02:00
|
|
|
=== on 13 Apr 2018, 14:34:09 Amaury Levé wrote:
|
2021-06-02 20:44:38 +02:00
|
|
|
\[~ann.campbell.2][~duncan.pocklington] Could you review please?
|
|
|
|
|
|
2021-06-03 09:05:38 +02:00
|
|
|
=== on 13 Apr 2018, 16:00:43 Duncan Pocklington wrote:
|
2021-06-02 20:44:38 +02:00
|
|
|
\[~amaury.leve] Looks good to me.
|
|
|
|
|
|
|
|
|
|
For (2), _wants a randomly-generated GUID_ is clearer than _a new GUID without specific initialization_
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
2021-06-03 09:05:38 +02:00
|
|
|
=== on 13 Apr 2018, 19:56:40 Ann Campbell wrote:
|
2021-06-02 20:44:38 +02:00
|
|
|
\[~amaury.leve] I don't think this qualifies as a bug.
|
|
|
|
|
|
2021-06-03 09:05:38 +02:00
|
|
|
=== on 16 Apr 2018, 11:51:13 Amaury Levé wrote:
|
2021-06-02 20:44:38 +02:00
|
|
|
\[~ann.campbell.2] Updated as Code Smell.
|
|
|
|
|
|
