rspec/rules/S907/vb6/rule.adoc

73 lines
1.7 KiB
Plaintext
Raw Normal View History

== Why is this an issue?
2024-12-18 15:06:04 +01:00
`GoTo` is an unstructured control flow statement. It makes code less readable and maintainable. Structured control flow statements such as `If`, `For`, `While`, or `Exit` should be used instead.
2020-06-30 12:50:59 +02:00
2024-12-18 15:06:04 +01:00
=== Exceptions
`On Error GoTo` statements are ignored as correct error handling.
== How to fix it
Replace `GoTo` statements with structured control flow statements.
=== Code examples
==== Noncompliant code example
2020-06-30 12:50:59 +02:00
2024-12-18 15:06:04 +01:00
[source,vb6,diff-id=1,diff-type=noncompliant]
2020-06-30 12:50:59 +02:00
----
2024-12-18 15:06:04 +01:00
Sub gotoStatementDemo()
Dim number As Integer = 1
Dim sampleString As String
' Evaluate number and branch to appropriate label.
If number = 1 Then GoTo Line1 Else GoTo Line2
2020-06-30 12:50:59 +02:00
Line1:
2024-12-18 15:06:04 +01:00
sampleString = "Number equals 1"
GoTo LastLine
2020-06-30 12:50:59 +02:00
Line2:
2024-12-18 15:06:04 +01:00
' The following statement never gets executed because number = 1.
sampleString = "Number equals 2"
2020-06-30 12:50:59 +02:00
LastLine:
2024-12-18 15:06:04 +01:00
' Write "Number equals 1" in the Debug window.
Debug.WriteLine(sampleString)
End Sub
2020-06-30 12:50:59 +02:00
----
2024-12-18 15:06:04 +01:00
==== Compliant solution
2020-06-30 12:50:59 +02:00
2024-12-18 15:06:04 +01:00
[source,vb6,diff-id=1,diff-type=compliant]
2020-06-30 12:50:59 +02:00
----
2024-12-18 15:06:04 +01:00
Sub gotoStatementDemo()
Dim number As Integer = 1
Dim sampleString As String
' Evaluate number and branch to appropriate label.
If number = 1 Then
sampleString = "Number equals 1"
Else
sampleString = "Number equals 2"
End If
Debug.WriteLine(sampleString)
End Sub
2020-06-30 12:50:59 +02:00
----
2024-12-18 15:06:04 +01:00
== Resources
=== Documentation
2020-06-30 12:50:59 +02:00
2024-12-18 15:06:04 +01:00
* Microsoft Learn - https://learn.microsoft.com/en-us/office/vba/language/reference/user-interface-help/goto-statement[GoTo statement]
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
include::../message.adoc[]
'''
== Comments And Links
(visible only on this page)
include::../comments-and-links.adoc[]
endif::env-github,rspecator-view[]