rspec/rules/S1821/php/rule.adoc

36 lines
757 B
Plaintext
Raw Normal View History

Nested `+switch+` structures are difficult to understand because you can easily confuse the cases of an inner `+switch+` as belonging to an outer statement. Therefore nested `+switch+` statements should be avoided.
2020-06-30 12:47:33 +02:00
Specifically, you should structure your code to avoid the need for nested `+switch+` statements, but if you cannot, then consider moving the inner `+switch+` to another function.
2020-06-30 12:47:33 +02:00
== Noncompliant Code Example
----
switch($a) {
case "foo":
switch($b) { // Noncompliant
case "bar":
doSomething();
break;
}
break;
}
----
== Compliant Solution
----
function handleFoo($foo) {
switch($foo) {
case "bar":
doSomething();
break;
}
}
switch($a) {
case "foo":
handleFoo($b);
break;
}
----