rspec/rules/S3923/scala/rule.adoc

55 lines
985 B
Plaintext
Raw Normal View History

== Why is this an issue?
Having all branches of a `match` or `if` chain with the same implementation indicates a problem.
2020-06-30 12:48:39 +02:00
In the following code:
2020-06-30 12:48:39 +02:00
2022-02-04 17:28:24 +01:00
[source,scala]
2020-06-30 12:48:39 +02:00
----
if (b == 0) { // Noncompliant
doSomething
} else {
doSomething
}
i match { // Noncompliant
case 1 => doSomething
case 2 => doSomething
case 3 => doSomething
case _ => doSomething
}
----
Either there is a copy-paste error that needs fixing or an unnecessary `match` or `if` chain that needs removing.
=== Exceptions
2020-06-30 12:48:39 +02:00
This rule does not apply to `if` chains without `else`, nor to `match` without a `case _` alternative.
2020-06-30 12:48:39 +02:00
2021-02-02 15:02:10 +01:00
[source,scala]
2020-06-30 12:48:39 +02:00
----
if (b == 0) {
doSomething
} else if (b == 1) {
doSomething
}
----
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
include::../message.adoc[]
include::../highlighting.adoc[]
'''
== Comments And Links
(visible only on this page)
include::../comments-and-links.adoc[]
endif::env-github,rspecator-view[]