29 lines
619 B
Plaintext
29 lines
619 B
Plaintext
|
=== How to fix it in Symfony
|
||
|
|
|
||
|
|
include::../../common/fix/code-rationale.adoc[]
|
||
|
|
|
||
|
|
==== Noncompliant code example
|
||
|
|
|
||
|
|
[source,php,diff-id=1,diff-type=noncompliant]
|
||
|
|
----
|
||
|
|
function route(): RedirectResponse {
|
||
|
|
$route = $request->get('route');
|
||
|
|
return $this->redirect($route); // Noncompliant
|
||
|
|
}
|
||
|
|
----
|
||
|
|
|
||
|
|
==== Compliant solution
|
||
|
|
|
||
|
|
[source,php,diff-id=1,diff-type=compliant]
|
||
|
|
----
|
||
|
|
function route(): RedirectResponse {
|
||
|
|
$route = $request->get('route');
|
||
|
|
return $this->redirectToRoute($route, [], 301);
|
||
|
|
}
|
||
|
|
----
|
||
|
|
|
||
|
|
include::../../common/fix/how-does-this-work.adoc[]
|
||
|
|
|
||
|
|
=== Pitfalls
|
||
|
|
|
||
|
|
include::../../common/pitfalls/starts-with.adoc[]
|