rspec/rules/S4144/python/rule.adoc

63 lines
1.2 KiB
Plaintext
Raw Normal View History

== Why is this an issue?
:func_name: function
2020-06-30 12:49:37 +02:00
include::../description.adoc[]
2020-06-30 12:49:37 +02:00
[source,python,diff-id=1,diff-type=noncompliant]
2020-06-30 12:49:37 +02:00
----
class MyClass:
code = "secret"
2020-06-30 12:49:37 +02:00
def calculate_code(self):
self.do_the_thing()
return self.__class__.code
def get_name(self): # Noncompliant: duplicates calculate_code
2020-06-30 12:49:37 +02:00
self.do_the_thing()
return self.__class__.code
def do_the_thing(self):
pass # on purpose
----
include::../inter.adoc[]
2020-06-30 12:49:37 +02:00
[source,python,diff-id=1,diff-type=compliant]
2020-06-30 12:49:37 +02:00
----
class MyClass:
code = "secret"
2020-06-30 12:49:37 +02:00
def calculate_code(self):
self.do_the_thing()
return self.__class__.code
def get_name(self): # Intent is clear
2020-06-30 12:49:37 +02:00
return self.calculate_code()
def do_the_thing(self):
pass # on purpose
----
=== Exceptions
2020-06-30 12:49:37 +02:00
No issue will be raised on empty methods/functions and methods/functions with only one line of code.
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
include::../message.adoc[]
include::../highlighting.adoc[]
'''
== Comments And Links
(visible only on this page)
include::../comments-and-links.adoc[]
endif::env-github,rspecator-view[]