2023-05-03 11:06:20 +02:00
|
|
|
== Why is this an issue?
|
|
|
|
|
2023-06-05 17:24:05 +02:00
|
|
|
:func_name: function
|
2020-06-30 12:49:37 +02:00
|
|
|
|
2023-06-05 17:24:05 +02:00
|
|
|
include::../description.adoc[]
|
2020-06-30 12:49:37 +02:00
|
|
|
|
2023-06-05 17:24:05 +02:00
|
|
|
[source,python,diff-id=1,diff-type=noncompliant]
|
2020-06-30 12:49:37 +02:00
|
|
|
----
|
|
|
|
class MyClass:
|
2023-06-05 17:24:05 +02:00
|
|
|
code = "secret"
|
2020-06-30 12:49:37 +02:00
|
|
|
|
|
|
|
def calculate_code(self):
|
|
|
|
self.do_the_thing()
|
|
|
|
return self.__class__.code
|
|
|
|
|
2023-06-05 17:24:05 +02:00
|
|
|
def get_name(self): # Noncompliant: duplicates calculate_code
|
2020-06-30 12:49:37 +02:00
|
|
|
self.do_the_thing()
|
|
|
|
return self.__class__.code
|
|
|
|
|
|
|
|
def do_the_thing(self):
|
|
|
|
pass # on purpose
|
|
|
|
----
|
|
|
|
|
2023-06-05 17:24:05 +02:00
|
|
|
include::../inter.adoc[]
|
2020-06-30 12:49:37 +02:00
|
|
|
|
2023-06-05 17:24:05 +02:00
|
|
|
[source,python,diff-id=1,diff-type=compliant]
|
2020-06-30 12:49:37 +02:00
|
|
|
----
|
|
|
|
class MyClass:
|
2023-06-05 17:24:05 +02:00
|
|
|
code = "secret"
|
2020-06-30 12:49:37 +02:00
|
|
|
|
|
|
|
def calculate_code(self):
|
|
|
|
self.do_the_thing()
|
|
|
|
return self.__class__.code
|
|
|
|
|
2023-06-05 17:24:05 +02:00
|
|
|
def get_name(self): # Intent is clear
|
2020-06-30 12:49:37 +02:00
|
|
|
return self.calculate_code()
|
|
|
|
|
|
|
|
def do_the_thing(self):
|
|
|
|
pass # on purpose
|
|
|
|
----
|
|
|
|
|
2023-05-03 11:06:20 +02:00
|
|
|
=== Exceptions
|
2020-06-30 12:49:37 +02:00
|
|
|
|
|
|
|
No issue will be raised on empty methods/functions and methods/functions with only one line of code.
|
2021-06-02 20:44:38 +02:00
|
|
|
|
2021-06-03 09:05:38 +02:00
|
|
|
ifdef::env-github,rspecator-view[]
|
2021-09-20 15:38:42 +02:00
|
|
|
|
|
|
|
'''
|
|
|
|
== Implementation Specification
|
|
|
|
(visible only on this page)
|
|
|
|
|
|
|
|
include::../message.adoc[]
|
|
|
|
|
|
|
|
include::../highlighting.adoc[]
|
|
|
|
|
2021-06-08 15:52:13 +02:00
|
|
|
'''
|
2021-06-02 20:44:38 +02:00
|
|
|
== Comments And Links
|
|
|
|
(visible only on this page)
|
|
|
|
|
|
|
|
include::../comments-and-links.adoc[]
|
2023-06-22 10:38:01 +02:00
|
|
|
|
2021-06-03 09:05:38 +02:00
|
|
|
endif::env-github,rspecator-view[]
|