rspec/rules/S1067/rpg/rule.adoc

36 lines
755 B
Plaintext
Raw Normal View History

2020-12-23 14:59:06 +01:00
The complexity of an expression is defined by the number of ``AND``, ``OR``.
2020-06-30 12:47:33 +02:00
A single expression's complexity should not become too high to keep the code readable.
== Noncompliant Code Example
With the default threshold value of 3
2020-06-30 12:47:33 +02:00
----
C IF (condition1 AND condition2)
C OR (condition2 AND condition2)
C OR (condition3 AND condition4)
----
----
/free
IF A=X OR A=Y AND A=Z AND B=Y OR B=Z;
...
ENDIF;
/end-free
----
== Compliant Solution
----
C IF (condition1 AND condition2)
C OR MyComplexCondition()
----
----
/free
IF A=X OR MyComplexCondition() OR B=Z;
...
ENDIF;
/end-free
----