rspec/rules/S1151/ruby/rule.adoc

40 lines
851 B
Plaintext
Raw Normal View History

2020-12-23 14:59:06 +01:00
The ``case`` statement should be used only to clearly define some new branches in the control flow. As soon as a ``when`` clause contains too many statements this highly decreases the readability of the overall control flow statement. In such case, the content of the case clause should be extracted into a dedicated function.
2020-06-30 12:47:33 +02:00
== Noncompliant Code Example
With the threshold set at 5:
2020-06-30 12:47:33 +02:00
----
case myVariable
when 0 then # Noncompliant: 6 lines till next "when"
methodCall1("")
methodCall2("")
methodCall3("")
methodCall4("")
methodCall5("")
methodCall6("")
when 1
# ...
end
----
== Compliant Solution
----
case myVariable
when 0 then
doSomething()
when 1
# ...
end
...
def doSomething()
methodCall1("")
methodCall2("")
methodCall3("")
methodCall4("")
methodCall5("")
methodCall6("")
end
----