2023-05-03 11:06:20 +02:00
|
|
|
== Why is this an issue?
|
|
|
|
|
2020-06-30 12:47:33 +02:00
|
|
|
include::../description.adoc[]
|
|
|
|
|
2023-10-17 11:56:12 +02:00
|
|
|
== How to fix it
|
2020-06-30 12:47:33 +02:00
|
|
|
|
2023-10-17 11:56:12 +02:00
|
|
|
include::../how-to-fix.adoc[]
|
|
|
|
|
|
|
|
=== Code examples
|
|
|
|
|
|
|
|
==== Noncompliant code example
|
|
|
|
|
|
|
|
[source,java,diff-id=1,diff-type=noncompliant]
|
2020-06-30 12:47:33 +02:00
|
|
|
----
|
|
|
|
public long computeDurationInMilliseconds() {
|
2023-10-17 11:56:12 +02:00
|
|
|
long duration = (((hours * 60) + minutes) * 60 + seconds) * 1000;
|
2020-06-30 12:47:33 +02:00
|
|
|
return duration;
|
|
|
|
}
|
2023-10-17 11:56:12 +02:00
|
|
|
----
|
2020-06-30 12:47:33 +02:00
|
|
|
|
2023-10-17 11:56:12 +02:00
|
|
|
==== Compliant solution
|
|
|
|
|
|
|
|
[source,java,diff-id=1,diff-type=compliant]
|
|
|
|
----
|
|
|
|
public long computeDurationInMilliseconds() {
|
|
|
|
return (((hours * 60) + minutes) * 60 + seconds) * 1000;
|
|
|
|
}
|
|
|
|
----
|
|
|
|
|
|
|
|
==== Noncompliant code example
|
|
|
|
|
|
|
|
[source,java,diff-id=2,diff-type=noncompliant]
|
|
|
|
----
|
2020-06-30 12:47:33 +02:00
|
|
|
public void doSomething() {
|
|
|
|
RuntimeException myException = new RuntimeException();
|
|
|
|
throw myException;
|
|
|
|
}
|
|
|
|
----
|
|
|
|
|
2023-10-17 11:56:12 +02:00
|
|
|
==== Compliant solution
|
2020-06-30 12:47:33 +02:00
|
|
|
|
2023-10-17 11:56:12 +02:00
|
|
|
[source,java,diff-id=2,diff-type=compliant]
|
2020-06-30 12:47:33 +02:00
|
|
|
----
|
|
|
|
public void doSomething() {
|
|
|
|
throw new RuntimeException();
|
|
|
|
}
|
|
|
|
----
|
2021-06-02 20:44:38 +02:00
|
|
|
|
2021-06-03 09:05:38 +02:00
|
|
|
ifdef::env-github,rspecator-view[]
|
2021-09-20 15:38:42 +02:00
|
|
|
|
|
|
|
'''
|
|
|
|
== Implementation Specification
|
|
|
|
(visible only on this page)
|
|
|
|
|
|
|
|
include::../message.adoc[]
|
|
|
|
|
2021-06-08 15:52:13 +02:00
|
|
|
'''
|
2021-06-02 20:44:38 +02:00
|
|
|
== Comments And Links
|
|
|
|
(visible only on this page)
|
|
|
|
|
|
|
|
include::../comments-and-links.adoc[]
|
2023-06-22 10:38:01 +02:00
|
|
|
|
2021-06-03 09:05:38 +02:00
|
|
|
endif::env-github,rspecator-view[]
|