68 lines
1.2 KiB
Plaintext
Raw Normal View History

== Why is this an issue?
:func_name: function
2020-06-30 12:49:37 +02:00
include::../description.adoc[]
2020-06-30 12:49:37 +02:00
[source,javascript,diff-id=1,diff-type=noncompliant]
2020-06-30 12:49:37 +02:00
----
function calculateCode() {
doTheThing();
doOtherThing();
return code;
}
function getName() { // Noncompliant: duplicates calculateCode
2020-06-30 12:49:37 +02:00
doTheThing();
doOtherThing();
return code;
}
----
include::../inter.adoc[]
2020-06-30 12:49:37 +02:00
[source,javascript,diff-id=1,diff-type=compliant]
2020-06-30 12:49:37 +02:00
----
function calculateCode() {
doTheThing();
doOtherThing();
return code;
}
function getName() { // Intent is clear
2020-06-30 12:49:37 +02:00
return calculateCode();
}
----
=== Exceptions
2020-06-30 12:49:37 +02:00
* Functions with fewer than 3 lines are ignored.
* This rule does not apply to function expressions and arrow functions because they don't have explicit names and are often used in a way where refactoring is not applicable.
[source,javascript]
----
list.map((item) => ({
name: item.name,
address: item.address,
country: item.country
}));
----
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
include::../message.adoc[]
include::../highlighting.adoc[]
'''
== Comments And Links
(visible only on this page)
include::../comments-and-links.adoc[]
endif::env-github,rspecator-view[]