2023-05-03 11:06:20 +02:00
== Why is this an issue?
2023-06-05 17:24:05 +02:00
:func_name: function
2020-06-30 12:49:37 +02:00
2023-06-05 17:24:05 +02:00
include::../description.adoc[]
2020-06-30 12:49:37 +02:00
2023-06-05 17:24:05 +02:00
[source,javascript,diff-id=1,diff-type=noncompliant]
2020-06-30 12:49:37 +02:00
----
function calculateCode() {
doTheThing();
doOtherThing();
return code;
}
2023-06-05 17:24:05 +02:00
function getName() { // Noncompliant: duplicates calculateCode
2020-06-30 12:49:37 +02:00
doTheThing();
doOtherThing();
return code;
}
----
2023-06-05 17:24:05 +02:00
include::../inter.adoc[]
2020-06-30 12:49:37 +02:00
2023-06-05 17:24:05 +02:00
[source,javascript,diff-id=1,diff-type=compliant]
2020-06-30 12:49:37 +02:00
----
function calculateCode() {
doTheThing();
doOtherThing();
return code;
}
2023-06-05 17:24:05 +02:00
function getName() { // Intent is clear
2020-06-30 12:49:37 +02:00
return calculateCode();
}
----
2023-05-03 11:06:20 +02:00
=== Exceptions
2020-06-30 12:49:37 +02:00
2022-08-08 15:27:34 +02:00
* Functions with fewer than 3 lines are ignored.
* This rule does not apply to function expressions and arrow functions because they don't have explicit names and are often used in a way where refactoring is not applicable.
[source,javascript]
----
list.map((item) => ({
name: item.name,
address: item.address,
country: item.country
}));
----
2021-06-02 20:44:38 +02:00
2021-06-03 09:05:38 +02:00
ifdef::env-github,rspecator-view[]
2021-09-20 15:38:42 +02:00
'''
== Implementation Specification
(visible only on this page)
include::../message.adoc[]
include::../highlighting.adoc[]
2021-06-08 15:52:13 +02:00
'''
2021-06-02 20:44:38 +02:00
== Comments And Links
(visible only on this page)
include::../comments-and-links.adoc[]
2021-06-03 09:05:38 +02:00
endif::env-github,rspecator-view[]