30 lines
1.1 KiB
Plaintext
30 lines
1.1 KiB
Plaintext
|
Using the same value on either side of a binary operator is almost always a mistake. In the case of logical operators, it is either a copy/paste error and therefore a bug, or it is simply wasted code, and should be simplified. In the case of bitwise operators and most binary mathematical operators, having the same value on both sides of an operator yields predictable results, and should be simplified.
|
||
|
|
|
||
|
|
Note that this rule will raise issues on <code>a == a</code> and <code>a != a</code> expressions which are sometime used to detect <code>NaN</code> values. It is recommended to use instead https://docs.python.org/3/library/math.html#math.isnan[<code>math.isnan</code>] or an equivalent function. This will improve code readability.
|
||
|
|
|
||
|
|
== Noncompliant Code Example
|
||
|
|
|
||
|
|
----
|
||
|
|
if a == a: # Noncompliant
|
||
|
|
work()
|
||
|
|
|
||
|
|
if a != a: # Noncompliant
|
||
|
|
work()
|
||
|
|
|
||
|
|
if a == b and a == b: # Noncompliant
|
||
|
|
work()
|
||
|
|
|
||
|
|
if a == b or a == b: # Noncompliant
|
||
|
|
work()
|
||
|
|
|
||
|
|
j = 5 / 5 # Noncompliant
|
||
|
|
k = 5 - 5 # Noncompliant
|
||
|
|
----
|
||
|
|
|
||
|
|
== Exceptions
|
||
|
|
|
||
|
|
The following are ignored:
|
||
|
|
* The expression <code>1 << 1</code>
|
||
|
|
|
||
|
|
include::../see.adoc[]
|