rspec/rules/S2388/java/rule.adoc

44 lines
894 B
Plaintext
Raw Normal View History

2021-04-28 16:49:39 +02:00
When an inner class extends another class, and both its outer class and its parent class have a method with the same name, calls to that method can be confusing. The compiler will resolve the call to the superclass method, but maintainers may be confused, so the superclass method should be called explicitly, using ``++super.++``.
== Noncompliant Code Example
----
public class Parent {
public void foo() { ... }
}
public class Outer {
public void foo() { ... }
public class Inner extends Parent {
public void doTheThing() {
foo(); // Noncompliant; was Outer.this.foo() intended instead?
// ...
}
}
}
----
== Compliant Solution
----
public class Parent {
public void foo() { ... }
}
public class Outer {
public void foo() { ... }
public class Inner extends Parent {
public void doTheThing() {
super.foo();
// ...
}
}
}
----