rspec/rules/S1192/php/rule.adoc

65 lines
1.2 KiB
Plaintext
Raw Normal View History

== Why is this an issue?
2020-06-30 12:47:33 +02:00
include::../description.adoc[]
=== Noncompliant code example
2020-06-30 12:47:33 +02:00
With the default threshold of 3:
2022-02-04 17:28:24 +01:00
[source,php]
2020-06-30 12:47:33 +02:00
----
function run() {
prepare('this is a duplicate'); // Noncompliant - 'this is a duplicate' is duplicated 3 times
execute('this is a duplicate');
release('this is a duplicate');
2020-06-30 12:47:33 +02:00
}
----
=== Compliant solution
2020-06-30 12:47:33 +02:00
2022-02-04 17:28:24 +01:00
[source,php]
2020-06-30 12:47:33 +02:00
----
MESSAGE = 'this is a duplicate';
2020-06-30 12:47:33 +02:00
function run() {
prepare(MESSAGE);
execute(MESSAGE);
release(MESSAGE);
2020-06-30 12:47:33 +02:00
}
----
=== Exceptions
No issue will be raised on:
* strings with less than 5 characters
* strings with only letters, numbers, underscores, hyphens and periods
[source,php]
----
$severity = $request->getParam('severity-score');
----
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
include::../message.adoc[]
include::../parameters.adoc[]
include::../highlighting.adoc[]
'''
== Comments And Links
(visible only on this page)
=== on 30 Jun 2020, 16:03:21 Ann Campbell wrote:
\[~nils.werner] "strings must start with a letter" doesn't make sense to me as an exception.
include::../comments-and-links.adoc[]
endif::env-github,rspecator-view[]