rspec/rules/S1172/php/rule.adoc

54 lines
857 B
Plaintext
Raw Normal View History

== Why is this an issue?
2020-06-30 12:47:33 +02:00
Unused parameters are misleading. Whatever the value passed to such parameters is, the behavior will be the same.
=== Noncompliant code example
2020-06-30 12:47:33 +02:00
2022-02-04 17:28:24 +01:00
[source,php]
2020-06-30 12:47:33 +02:00
----
function doSomething($a, $b) { // "$a" is unused
return compute($b);
}
----
=== Compliant solution
2020-06-30 12:47:33 +02:00
2022-02-04 17:28:24 +01:00
[source,php]
2020-06-30 12:47:33 +02:00
----
function doSomething($b) {
return compute($b);
}
----
=== Exceptions
2020-06-30 12:47:33 +02:00
Functions in classes that override a class or implement interfaces are ignored.
[source,php]
2020-06-30 12:47:33 +02:00
----
class C extends B {
function doSomething($a, $b) { // no issue reported on $b
compute($a);
}
}
----
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
include::../message.adoc[]
'''
== Comments And Links
(visible only on this page)
include::../comments-and-links.adoc[]
endif::env-github,rspecator-view[]