2020-06-30 12:48:07 +02:00
|
|
|
include::../description.adoc[]
|
|
|
|
|
|
|
|
== Noncompliant Code Example
|
|
|
|
|
2022-02-04 17:28:24 +01:00
|
|
|
[source,csharp]
|
2020-06-30 12:48:07 +02:00
|
|
|
----
|
|
|
|
using System;
|
|
|
|
using Microsoft.AspNetCore.Mvc;
|
|
|
|
|
|
|
|
namespace WebApplicationDotNetCore.Controllers
|
|
|
|
{
|
|
|
|
public class RSPEC2083IOInjectionNoncompliantController : Controller
|
|
|
|
{
|
|
|
|
public IActionResult Index()
|
|
|
|
{
|
|
|
|
return View();
|
|
|
|
}
|
|
|
|
|
|
|
|
public IActionResult DeleteFile(string fileName)
|
|
|
|
{
|
|
|
|
System.IO.File.Delete(fileName); // Noncompliant
|
|
|
|
|
|
|
|
return Content("File " + fileName + " deleted");
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
----
|
|
|
|
|
|
|
|
== Compliant Solution
|
|
|
|
|
2022-02-04 17:28:24 +01:00
|
|
|
[source,csharp]
|
2020-06-30 12:48:07 +02:00
|
|
|
----
|
|
|
|
using System;
|
|
|
|
using System.IO;
|
|
|
|
using Microsoft.AspNetCore.Mvc;
|
|
|
|
|
|
|
|
namespace WebApplicationDotNetCore.Controllers
|
|
|
|
{
|
|
|
|
public class RSPEC2083IOInjectionCompliantController : Controller
|
|
|
|
{
|
|
|
|
public IActionResult Index()
|
|
|
|
{
|
|
|
|
return View();
|
|
|
|
}
|
|
|
|
|
|
|
|
public IActionResult DeleteFile(string fileName)
|
|
|
|
{
|
|
|
|
string destDirectory = "~/CustomersData/";
|
|
|
|
|
|
|
|
string destFileName = Path.GetFullPath(System.IO.Path.Combine(destDirectory, fileName));
|
|
|
|
string fullDestDirPath = Path.GetFullPath(destDirectory + Path.DirectorySeparatorChar);
|
|
|
|
|
2022-02-10 09:06:19 +01:00
|
|
|
if (destFileName.StartsWith(fullDestDirPath, StringComparison.Ordinal))
|
2020-06-30 12:48:07 +02:00
|
|
|
{
|
|
|
|
System.IO.File.Delete(destFileName); // Compliant
|
|
|
|
return Content("File " + fileName + " deleted");
|
|
|
|
} else
|
|
|
|
{
|
|
|
|
return BadRequest();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
}
|
|
|
|
}
|
|
|
|
----
|
|
|
|
|
|
|
|
include::../see.adoc[]
|
2021-06-02 20:44:38 +02:00
|
|
|
|
2021-06-03 09:05:38 +02:00
|
|
|
ifdef::env-github,rspecator-view[]
|
2021-09-20 15:38:42 +02:00
|
|
|
|
|
|
|
'''
|
|
|
|
== Implementation Specification
|
|
|
|
(visible only on this page)
|
|
|
|
|
|
|
|
include::../message.adoc[]
|
|
|
|
|
2021-06-08 15:52:13 +02:00
|
|
|
'''
|
2021-06-02 20:44:38 +02:00
|
|
|
== Comments And Links
|
|
|
|
(visible only on this page)
|
|
|
|
|
|
|
|
include::../comments-and-links.adoc[]
|
2021-06-03 09:05:38 +02:00
|
|
|
endif::env-github,rspecator-view[]
|