rspec/rules/S2083/java/rule.adoc

57 lines
1.2 KiB
Plaintext
Raw Normal View History

2020-06-30 12:48:07 +02:00
include::../description.adoc[]
== Noncompliant Code Example
2022-02-04 17:28:24 +01:00
[source,java]
2020-06-30 12:48:07 +02:00
----
protected void doGet(HttpServletRequest req, HttpServletResponse resp) throws IOException {
String file = request.getParameter("file");
File fileUnsafe = new File(file);
try {
FileUtils.forceDelete(fileUnsafe); // Noncompliant
}
catch(IOException ex){
System.out.println (ex.toString());
}
}
----
== Compliant Solution
2022-02-04 17:28:24 +01:00
[source,java]
2020-06-30 12:48:07 +02:00
----
protected void doGet(HttpServletRequest req, HttpServletResponse resp) throws IOException {
String file = request.getParameter("file");
File fileUnsafe = new File(file);
File directory = new File("/tmp/");
try {
if(FileUtils.directoryContains(directory, fileUnsafe)) {
FileUtils.forceDelete(fileUnsafe); // Compliant
}
}
catch(IOException ex){
System.out.println (ex.toString());
}
}
----
include::../see.adoc[]
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
include::../message.adoc[]
'''
== Comments And Links
(visible only on this page)
include::../comments-and-links.adoc[]
endif::env-github,rspecator-view[]