2023-05-03 11:06:20 +02:00
|
|
|
== Why is this an issue?
|
|
|
|
|
2020-06-30 12:48:39 +02:00
|
|
|
include::../description.adoc[]
|
|
|
|
|
2023-05-03 11:06:20 +02:00
|
|
|
=== Noncompliant code example
|
2020-06-30 12:48:39 +02:00
|
|
|
|
2022-02-04 17:28:24 +01:00
|
|
|
[source,php]
|
2020-06-30 12:48:39 +02:00
|
|
|
----
|
2020-12-21 15:38:52 +01:00
|
|
|
function get_readable_status($is_running, $has_errors) {
|
|
|
|
return $is_running ? "Running" : ($has_errors ? "Failure" : "Succeeded"); // Noncompliant
|
2020-06-30 12:48:39 +02:00
|
|
|
}
|
|
|
|
----
|
|
|
|
|
2023-05-03 11:06:20 +02:00
|
|
|
=== Compliant solution
|
2020-06-30 12:48:39 +02:00
|
|
|
|
2022-02-04 17:28:24 +01:00
|
|
|
[source,php]
|
2020-06-30 12:48:39 +02:00
|
|
|
----
|
2020-12-21 15:38:52 +01:00
|
|
|
function get_readable_status($is_running, $has_errors) {
|
|
|
|
if ($is_running) {
|
|
|
|
return "Running";
|
2020-06-30 12:48:39 +02:00
|
|
|
}
|
2020-12-21 15:38:52 +01:00
|
|
|
return $has_errors ? "Failure. " : "Succeeded ";
|
2020-06-30 12:48:39 +02:00
|
|
|
}
|
|
|
|
----
|
2021-01-06 17:38:34 +01:00
|
|
|
|
2023-05-03 11:06:20 +02:00
|
|
|
=== Exceptions
|
2021-01-06 17:38:34 +01:00
|
|
|
|
2021-01-27 13:42:22 +01:00
|
|
|
Exclusively chained shorthand ternary operators ``++?:++`` are excluded from this rule.
|
2021-01-06 17:38:34 +01:00
|
|
|
|
2023-05-25 14:18:12 +02:00
|
|
|
[source,php]
|
2021-01-06 17:38:34 +01:00
|
|
|
----
|
|
|
|
$result = $option1 ?: $option2 ?: 'default';
|
|
|
|
----
|
2021-06-02 20:44:38 +02:00
|
|
|
|
2021-06-03 09:05:38 +02:00
|
|
|
ifdef::env-github,rspecator-view[]
|
2021-09-20 15:38:42 +02:00
|
|
|
|
|
|
|
'''
|
|
|
|
== Implementation Specification
|
|
|
|
(visible only on this page)
|
|
|
|
|
|
|
|
include::../message.adoc[]
|
|
|
|
|
|
|
|
include::../highlighting.adoc[]
|
|
|
|
|
2021-06-08 15:52:13 +02:00
|
|
|
'''
|
2021-06-02 20:44:38 +02:00
|
|
|
== Comments And Links
|
|
|
|
(visible only on this page)
|
|
|
|
|
|
|
|
include::../comments-and-links.adoc[]
|
2021-06-03 09:05:38 +02:00
|
|
|
endif::env-github,rspecator-view[]
|