rspec/rules/S3365/java/rule.adoc

54 lines
823 B
Plaintext
Raw Normal View History

== Why is this an issue?
2021-04-28 16:49:39 +02:00
Once set, the value of a Hibernate ``++@Entity++``'s ``++@Id++`` field/column should never be updated. Therefore, setters for such fields should always be ``++private++``.
=== Noncompliant code example
2021-04-28 16:49:39 +02:00
2022-02-04 17:28:24 +01:00
[source,java]
2021-04-28 16:49:39 +02:00
----
public class Book {
@Id
@GeneratedValue
private int id;
public void setId(int id) { // Noncompliant
this.id = id;
}
----
=== Compliant solution
2021-04-28 16:49:39 +02:00
2022-02-04 17:28:24 +01:00
[source,java]
2021-04-28 16:49:39 +02:00
----
public class Book {
@Id
@GeneratedValue
private int id;
private void setId(int id) {
this.id = id;
}
----
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
=== Message
Make this setter "private".
=== Highlighting
* primary: visibility modifier, or method name if ``++protected++``
endif::env-github,rspecator-view[]