rspec/rules/S1217/java/rule.adoc

53 lines
1.2 KiB
Plaintext
Raw Normal View History

== Why is this an issue?
2021-04-28 16:49:39 +02:00
The purpose of the ``++Thread.run()++`` method is to execute code in a separate, dedicated thread. Calling this method directly doesn't make sense because it causes its code to be executed in the current thread.
To get the expected behavior, call the ``++Thread.start()++`` method instead.
=== Noncompliant code example
2021-04-28 16:49:39 +02:00
2022-02-04 17:28:24 +01:00
[source,java]
2021-04-28 16:49:39 +02:00
----
Thread myThread = new Thread(runnable);
myThread.run(); // Noncompliant
----
=== Compliant solution
2021-04-28 16:49:39 +02:00
2022-02-04 17:28:24 +01:00
[source,java]
2021-04-28 16:49:39 +02:00
----
Thread myThread = new Thread(runnable);
myThread.start(); // Compliant
----
== Resources
2021-04-28 16:49:39 +02:00
* https://cwe.mitre.org/data/definitions/572[MITRE, CWE-572] - Call to Thread run() instead of start()
2021-04-28 16:49:39 +02:00
* https://wiki.sei.cmu.edu/confluence/x/6DdGBQ[CERT THI00-J.] - Do not invoke Thread.run()
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
=== Message
Call the method Thread.start() to execute the content of the run() method in a dedicated thread.
'''
== Comments And Links
(visible only on this page)
=== on 20 Aug 2013, 15:40:32 Freddy Mallet wrote:
Is implemented by \http://jira.codehaus.org/browse/SONARJAVA-308
endif::env-github,rspecator-view[]