rspec/rules/S1067/rpg/rule.adoc

61 lines
1.1 KiB
Plaintext
Raw Normal View History

== Why is this an issue?
2021-01-27 13:42:22 +01:00
The complexity of an expression is defined by the number of ``++AND++``, ``++OR++``.
2021-02-02 15:02:10 +01:00
2020-06-30 12:47:33 +02:00
A single expression's complexity should not become too high to keep the code readable.
=== Noncompliant code example
2020-06-30 12:47:33 +02:00
With the default threshold value of 3
2022-02-04 17:28:24 +01:00
[source,rpg]
2020-06-30 12:47:33 +02:00
----
C IF (condition1 AND condition2)
C OR (condition2 AND condition2)
C OR (condition3 AND condition4)
----
2022-02-04 17:28:24 +01:00
[source,rpg]
2020-06-30 12:47:33 +02:00
----
/free
IF A=X OR A=Y AND A=Z AND B=Y OR B=Z;
...
ENDIF;
/end-free
----
=== Compliant solution
2020-06-30 12:47:33 +02:00
2022-02-04 17:28:24 +01:00
[source,rpg]
2020-06-30 12:47:33 +02:00
----
C IF (condition1 AND condition2)
C OR MyComplexCondition()
----
2022-02-04 17:28:24 +01:00
[source,rpg]
2020-06-30 12:47:33 +02:00
----
/free
IF A=X OR MyComplexCondition() OR B=Z;
...
ENDIF;
/end-free
----
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
include::../message.adoc[]
include::../parameters.adoc[]
'''
== Comments And Links
(visible only on this page)
include::../comments-and-links.adoc[]
endif::env-github,rspecator-view[]