rspec/rules/S1186/php/rule.adoc

55 lines
1.1 KiB
Plaintext
Raw Normal View History

2020-06-30 12:47:33 +02:00
There are several reasons for a method not to have a method body:
* It is an unintentional omission and should be fixed to prevent unexpected behavior in production.
2021-01-27 13:42:22 +01:00
* It is not yet, or never will be, supported. In this case an ``++UnsupportedOperationException++`` should be thrown.
* The method is an intentionally-blank override. In this case a nested comment should explain the reason for the blank override.
2020-06-30 12:47:33 +02:00
== Noncompliant Code Example
2022-02-04 17:28:24 +01:00
[source,php]
2020-06-30 12:47:33 +02:00
----
public function doSomething() {
}
public function doSomethingElse() {
}
----
== Compliant Solution
2022-02-04 17:28:24 +01:00
[source,php]
2020-06-30 12:47:33 +02:00
----
public function doSomething() {
// Do nothing because of X and Y.
}
public function doSomethingElse() {
throw new UnsupportedOperationException();
}
----
== Exceptions
Empty methods in abstract classes
2020-06-30 12:47:33 +02:00
----
abstract class Animal {
public function speak() {} // default implementation ignored
}
----
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
include::../message.adoc[]
'''
== Comments And Links
(visible only on this page)
include::../comments-and-links.adoc[]
endif::env-github,rspecator-view[]