2021-01-27 13:42:22 +01:00
|
|
|
Nested ``++IF...ELSE++``, ``++WHILE++`` and ``++TRY...CATCH++`` statements is a key ingredient for making what's known as "Spaghetti code".
|
2020-06-30 12:47:33 +02:00
|
|
|
|
2021-02-02 15:02:10 +01:00
|
|
|
|
2020-06-30 12:47:33 +02:00
|
|
|
Such code is hard to read, refactor and therefore maintain.
|
|
|
|
|
|
|
|
== Noncompliant Code Example
|
|
|
|
|
|
|
|
With the default threshold of 4:
|
2020-06-30 14:49:38 +02:00
|
|
|
|
2022-02-04 17:28:24 +01:00
|
|
|
[source,sql]
|
2020-06-30 12:47:33 +02:00
|
|
|
----
|
|
|
|
IF @flag1 = 1 -- Compliant - depth = 1
|
|
|
|
BEGIN
|
|
|
|
IF @flag2 = 2 -- Compliant - depth = 2
|
|
|
|
BEGIN
|
|
|
|
WHILE @var1 > 0 -- Compliant - depth = 3
|
|
|
|
BEGIN
|
|
|
|
IF @flag3 = 3 -- Compliant - depth = 4, not exceeding the limit
|
|
|
|
BEGIN
|
|
|
|
IF @flag4 = 4 -- Noncompliant - depth = 5
|
|
|
|
BEGIN
|
|
|
|
IF @flag5 = 5 -- Depth = 6, exceeding the limit, but issues are only reported on depth = 5
|
|
|
|
BREAK
|
|
|
|
END
|
|
|
|
END
|
|
|
|
SET @var1 = @var1 - 1
|
|
|
|
END
|
|
|
|
END
|
|
|
|
END
|
|
|
|
----
|
2021-06-02 20:44:38 +02:00
|
|
|
|
2021-06-03 09:05:38 +02:00
|
|
|
ifdef::env-github,rspecator-view[]
|
2021-09-20 15:38:42 +02:00
|
|
|
|
|
|
|
'''
|
|
|
|
== Implementation Specification
|
|
|
|
(visible only on this page)
|
|
|
|
|
|
|
|
include::../message.adoc[]
|
|
|
|
|
|
|
|
include::parameters.adoc[]
|
|
|
|
|
|
|
|
include::../highlighting.adoc[]
|
|
|
|
|
2021-06-08 15:52:13 +02:00
|
|
|
'''
|
2021-06-02 20:44:38 +02:00
|
|
|
== Comments And Links
|
|
|
|
(visible only on this page)
|
|
|
|
|
|
|
|
include::comments-and-links.adoc[]
|
2021-06-03 09:05:38 +02:00
|
|
|
endif::env-github,rspecator-view[]
|