rspec/rules/S3963/csharp/rule.adoc

61 lines
1.1 KiB
Plaintext
Raw Normal View History

2021-04-28 16:49:39 +02:00
When a ``++static++`` constructor serves no other purpose that initializing ``++static++`` fields, it comes with an unnecessary performance cost because the compiler generates a check before each ``++static++`` method or instance constructor invocation.
Instead, inline initialization is highly recommended.
2021-04-28 16:49:39 +02:00
== Noncompliant Code Example
2022-02-04 17:28:24 +01:00
[source,csharp]
2021-04-28 16:49:39 +02:00
----
namespace myLib
{
public class Foo
{
static int i;
static string s;
static Foo() // Noncompliant
{
i = 3;
ResourceManager sm = new ResourceManager("strings", Assembly.GetExecutingAssembly());
s = sm.GetString("mystring");
}
}
}
----
2021-04-28 16:49:39 +02:00
== Compliant Solution
2022-02-04 17:28:24 +01:00
[source,csharp]
2021-04-28 16:49:39 +02:00
----
namespace myLib
{
public class Foo
{
static int i =3;
static string s = InitString();
static string InitString()
{
ResourceManager sm = new ResourceManager("strings", Assembly.GetExecutingAssembly());
return sm.GetString("mystring");
}
}
}
----
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
include::message.adoc[]
include::highlighting.adoc[]
endif::env-github,rspecator-view[]