2020-06-30 12:49:37 +02:00
When two functions or methods have the same implementation, either it was a mistake - something else was intended - or the duplication was intentional, but may be confusing to maintainers. In the latter case, one implementation should invoke the other. Numerical and string literals are not taken into account.
== Noncompliant Code Example
2022-02-04 17:28:24 +01:00
[source,python]
2020-06-30 12:49:37 +02:00
----
class MyClass:
code = "bounteous"
def calculate_code(self):
self.do_the_thing()
return self.__class__.code
def get_name(self): # Noncompliant
self.do_the_thing()
return self.__class__.code
def do_the_thing(self):
pass # on purpose
----
== Compliant Solution
2022-02-04 17:28:24 +01:00
[source,python]
2020-06-30 12:49:37 +02:00
----
class MyClass:
code = "bounteous"
def calculate_code(self):
self.do_the_thing()
return self.__class__.code
def get_name(self):
return self.calculate_code()
def do_the_thing(self):
pass # on purpose
----
== Exceptions
No issue will be raised on empty methods/functions and methods/functions with only one line of code.
2021-06-02 20:44:38 +02:00
2021-06-03 09:05:38 +02:00
ifdef::env-github,rspecator-view[]
2021-09-20 15:38:42 +02:00
'''
== Implementation Specification
(visible only on this page)
include::../message.adoc[]
include::../highlighting.adoc[]
2021-06-08 15:52:13 +02:00
'''
2021-06-02 20:44:38 +02:00
== Comments And Links
(visible only on this page)
include::../comments-and-links.adoc[]
2021-06-03 09:05:38 +02:00
endif::env-github,rspecator-view[]