rspec/rules/S4144/python/rule.adoc

60 lines
1.3 KiB
Plaintext
Raw Normal View History

2020-06-30 12:49:37 +02:00
When two functions or methods have the same implementation, either it was a mistake - something else was intended - or the duplication was intentional, but may be confusing to maintainers. In the latter case, one implementation should invoke the other. Numerical and string literals are not taken into account.
== Noncompliant Code Example
2022-02-04 17:28:24 +01:00
[source,python]
2020-06-30 12:49:37 +02:00
----
class MyClass:
code = "bounteous"
def calculate_code(self):
self.do_the_thing()
return self.__class__.code
def get_name(self): # Noncompliant
self.do_the_thing()
return self.__class__.code
def do_the_thing(self):
pass # on purpose
----
== Compliant Solution
2022-02-04 17:28:24 +01:00
[source,python]
2020-06-30 12:49:37 +02:00
----
class MyClass:
code = "bounteous"
def calculate_code(self):
self.do_the_thing()
return self.__class__.code
def get_name(self):
return self.calculate_code()
def do_the_thing(self):
pass # on purpose
----
== Exceptions
No issue will be raised on empty methods/functions and methods/functions with only one line of code.
ifdef::env-github,rspecator-view[]
'''
== Implementation Specification
(visible only on this page)
include::../message.adoc[]
include::../highlighting.adoc[]
'''
== Comments And Links
(visible only on this page)
include::../comments-and-links.adoc[]
endif::env-github,rspecator-view[]