25 lines
606 B
Plaintext
25 lines
606 B
Plaintext
|
An <code>except</code> clause that only rethrows the caught exception has the same effect as omitting the <code>except</code> altogether and letting it bubble up automatically, but with more code and the additional detriment of leaving maintainers scratching their heads.
|
||
|
|
|
||
|
|
Such clauses should either be eliminated or populated with the appropriate logic.
|
||
|
|
|
||
|
|
== Noncompliant Code Example
|
||
|
|
|
||
|
|
----
|
||
|
|
a = {}
|
||
|
|
try:
|
||
|
|
a[5]
|
||
|
|
except KeyError:
|
||
|
|
raise # Noncompliant
|
||
|
|
----
|
||
|
|
|
||
|
|
== Compliant Solution
|
||
|
|
|
||
|
|
----
|
||
|
|
a = {}
|
||
|
|
try:
|
||
|
|
a[5]
|
||
|
|
except KeyError as e:
|
||
|
|
logging.exception('error while accessing the dict')
|
||
|
|
raise e
|
||
|
|
----
|