2023-05-03 11:06:20 +02:00
== Why is this an issue?
2021-01-27 13:42:22 +01:00
The ``++switch++`` statement should be used only to clearly define some new branches in the control flow. As soon as a ``++when++`` clause contains too many statements this highly decreases the readability of the overall control flow statement. In such case, the content of the ``++when++`` clause should be extracted into a dedicated function.
2020-06-30 12:47:33 +02:00
2023-05-03 11:06:20 +02:00
=== Noncompliant code example
2020-06-30 12:47:33 +02:00
2021-01-27 13:42:22 +01:00
With the threshold set at ``++5++``:
2020-06-30 14:49:38 +02:00
2022-02-04 17:28:24 +01:00
[source,apex]
2020-06-30 12:47:33 +02:00
----
public void foo(Integer value) {
switch on value {
when 1 {
methodCall1('');
methodCall2('');
methodCall3('');
methodCall4('');
methodCall5('');
}
when 2 { /* ... */ }
}
}
----
2023-05-03 11:06:20 +02:00
=== Compliant solution
2020-06-30 12:47:33 +02:00
2022-02-04 17:28:24 +01:00
[source,apex]
2020-06-30 12:47:33 +02:00
----
public void foo(Integer value) {
switch on value {
when 1 { doSomething(); }
when 2 { /* ... */ }
}
}
}
private void doSomething() {
methodCall1('');
methodCall2('');
methodCall3('');
methodCall4('');
methodCall5('');
}
----
2021-06-02 20:44:38 +02:00
2021-06-03 09:05:38 +02:00
ifdef::env-github,rspecator-view[]
2021-09-20 15:38:42 +02:00
'''
== Implementation Specification
(visible only on this page)
include::../message.adoc[]
include::../parameters.adoc[]
2021-06-08 15:52:13 +02:00
'''
2021-06-02 20:44:38 +02:00
== Comments And Links
(visible only on this page)
include::../comments-and-links.adoc[]
2023-06-22 10:38:01 +02:00
2021-06-03 09:05:38 +02:00
endif::env-github,rspecator-view[]